[Improvement-#11768][Monitor] Support monitor h2 database in monitor page#11813
Merged
ruanwenjun merged 2 commits intoapache:devfrom Sep 9, 2022
Merged
[Improvement-#11768][Monitor] Support monitor h2 database in monitor page#11813ruanwenjun merged 2 commits intoapache:devfrom
ruanwenjun merged 2 commits intoapache:devfrom
Conversation
DarkAssassinator
requested review from
SbloodyS and
caishunfeng
as code owners
SbloodyS
reviewed
Sep 7, 2022
|
|
||
| try { | ||
| pstmt = conn.createStatement(); | ||
| try (ResultSet rs1 = pstmt.executeQuery("select count(*) as total from information_schema.sessions;")) { |
Member
There was a problem hiding this comment.
Suggested change
| try (ResultSet rs1 = pstmt.executeQuery("select count(*) as total from information_schema.sessions;")) { | |
| try (ResultSet rs1 = pstmt.executeQuery("select count(1) as total from information_schema.sessions;")) { |
Contributor
Author
There was a problem hiding this comment.
done. but i still think that count(1) ≈ count(*)
ruanwenjun
reviewed
Sep 7, 2022
|
|
||
| Statement pstmt = null; | ||
|
|
||
| try { |
Member
There was a problem hiding this comment.
Please use try-with-resource to close the Statement
Contributor
Author
There was a problem hiding this comment.
Please use try-with-resource to close the
Statement
done. thx.
|
SonarCloud Quality Gate failed. |
ruanwenjun
changed the title
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Sep 10, 2022
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Sep 10, 2022
caishunfeng
added
the
release cherry-pick
caishunfeng
pushed a commit
that referenced
this pull request
Sep 19, 2022
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…1768
Purpose of the pull request
fix #11768
Brief change log
add H2 db performace monitor
Verify this pull request
This pull request is code cleanup without any test coverage.
Just add connection sessions monitor, becasue H2 DB do not have MAX_CONNECTION setting.