Skip to content

[Bug] Fix process instance display and npe when save#11954

Closed
106umao wants to merge 5 commits intoapache:devfrom
106umao:fix/pd-npe
Closed

[Bug] Fix process instance display and npe when save#11954
106umao wants to merge 5 commits intoapache:devfrom
106umao:fix/pd-npe

Conversation

@106umao
Copy link
Copy Markdown
Contributor

@106umao 106umao commented Sep 15, 2022

When workflow definitions are removed, their associated workflow instances should be displayed

@106umao 106umao requested review from ruanwenjun and removed request for SbloodyS and caishunfeng September 15, 2022 15:03
@SbloodyS SbloodyS added the bug Something isn't working label Sep 16, 2022
@SbloodyS SbloodyS added this to the 3.1.0 milestone Sep 16, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #11954 (932b752) into dev (ad683c3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #11954      +/-   ##
============================================
- Coverage     38.68%   38.66%   -0.02%     
+ Complexity     4006     4003       -3     
============================================
  Files          1002     1001       -1     
  Lines         37213    37425     +212     
  Branches       4249     4265      +16     
============================================
+ Hits          14394    14472      +78     
- Misses        21186    21307     +121     
- Partials       1633     1646      +13     
Impacted Files Coverage Δ
...r/api/service/impl/ProcessInstanceServiceImpl.java 57.30% <0.00%> (-0.41%) ⬇️
...scheduler/plugin/task/mlflow/MlflowParameters.java 18.18% <0.00%> (-56.05%) ⬇️
...heduler/plugin/task/jupyter/JupyterParameters.java 0.00% <0.00%> (-33.34%) ⬇️
...eduler/server/worker/task/WorkerHeartBeatTask.java 69.38% <0.00%> (-8.17%) ⬇️
...hinscheduler/plugin/alert/script/ScriptSender.java 53.33% <0.00%> (-7.28%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
.../dolphinscheduler/plugin/task/spark/SparkTask.java 72.80% <0.00%> (-1.76%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.42% <0.00%> (-1.43%) ⬇️
... and 32 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@106umao
Copy link
Copy Markdown
Contributor Author

106umao commented Sep 21, 2022

will do it

@mergeable
Copy link
Copy Markdown

mergeable bot commented Sep 22, 2022

⚠️ This PR do not change database DDL synchronize.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@caishunfeng caishunfeng changed the title fix process instance display and npe when save [Bug] Fix process instance display and npe when save Sep 27, 2022
@caishunfeng caishunfeng modified the milestones: 3.1.0, 3.1.1 Sep 27, 2022
@zhuangchong zhuangchong modified the milestones: 3.1.1, 3.1.2 Nov 4, 2022
@zhuangchong zhuangchong modified the milestones: 3.1.2, 3.1.3 Dec 7, 2022
@zhuangchong zhuangchong modified the milestones: 3.1.3, 3.1.4 Jan 3, 2023
@zhuangchong zhuangchong modified the milestones: 3.1.4, 3.1.5 Feb 21, 2023
@zhuangchong zhuangchong modified the milestones: 3.1.5, 3.1.6 Apr 6, 2023
@zhuangchong zhuangchong modified the milestones: 3.1.6, 3.2.0 May 10, 2023
@zhongjiajie zhongjiajie modified the milestones: 3.2.0, 3.3.0 Aug 30, 2023
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Feb 23, 2024
@SbloodyS SbloodyS closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants