Skip to content

[fix#12243] Fixed the issue of permission to create task-related files during Python task execution#11959

Closed
pandong2011 wants to merge 119 commits intoapache:devfrom
pandong2011:dev
Closed

[fix#12243] Fixed the issue of permission to create task-related files during Python task execution#11959
pandong2011 wants to merge 119 commits intoapache:devfrom
pandong2011:dev

Conversation

@pandong2011
Copy link
Contributor

@pandong2011 pandong2011 commented Sep 15, 2022

Purpose of the pull request

close #12243
related issue #11544
related issue #11913

Brief change log

Verify this pull request

Manually verified the change by testing locally.

@pandong2011
Copy link
Contributor Author

@kezhenxu94 @caishunfeng

@fhygh
Copy link

fhygh commented Sep 16, 2022

@pandong2011 hello, i cherry-pick this pr but found it does not work, can you help check again?

@SbloodyS SbloodyS added the first time contributor First-time contributor label Sep 16, 2022
@SbloodyS SbloodyS added this to the 3.1.0 milestone Sep 16, 2022
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Sep 16, 2022
@pandong2011
Copy link
Contributor Author

@fhygh Okay, sure

ruanwenjun and others added 10 commits September 16, 2022 15:39
Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>
…according… (#11782)

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Resolve conflict.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- fix ProcessDefinitionServiceImpl.java dependency

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Accept proposed change in ResourcePermissionCheckServiceImpl.java

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Update the UT case in TenantServiceTest.java, UsersServiceTest.java, TaskGroupServiceTest.java.
- Update log printing in TaskGroupServiceImpl.java.
- Fix NPE of log parameter in ExecutorServiceImpl.java when call python api.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Fix NPE of log in WorkerGroupServiceImpl.java.
- Fix log parameter missing bug in ResourcesServiceImpl.java.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Fix bugs and handle some vulnerability codes.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Fix bugs and handle some vulnerability codes.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Fix e2e User test.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Fix codeQL check & SonarCloud Code Analysis.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Resolve import conflict.

* [DS-11773][api] Optimize the log printing of the api module according to the log specification doc.
- Fix codeQL check & SonarCloud Code Analysis.
* [improve] support test tasks

* [improve] support test tasks

* [improve] support test tasks

* [improve] support test tasks

* [improve] support test tasks

* Update TaskExecuteThread.java

* try solve e2e q

* try solve e2e q

* try solve e2e q

* try solve e2e q

* try solve e2e q

* try solve e2e q

* try solve e2e q

* try solve e2e q

* try solve e2e q

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* Update DataSource.java

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* Update messages_zh_CN.properties

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* Update messages.properties

* Update messages_en_US.properties

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks

* [Feature] support test tasks
Using the whole word zookeeper instead of short cut zk
Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>
* add dvc task in pyds

* add BaseDVC class
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #11959 (87eb6c0) into dev (e70c501) will increase coverage by 1.15%.
The diff coverage is 54.66%.

@@             Coverage Diff              @@
##                dev   #11959      +/-   ##
============================================
+ Coverage     38.55%   39.70%   +1.15%     
- Complexity     4034     4190     +156     
============================================
  Files           993     1016      +23     
  Lines         36673    38061    +1388     
  Branches       4274     4368      +94     
============================================
+ Hits          14138    15112     +974     
- Misses        20912    21204     +292     
- Partials       1623     1745     +122     
Impacted Files Coverage Δ
...olphinscheduler/api/audit/AuditPublishService.java 34.61% <0.00%> (ø)
...duler/api/configuration/TaskTypeConfiguration.java 13.63% <0.00%> (+2.92%) ⬆️
...phinscheduler/api/controller/TenantController.java 62.50% <ø> (ø)
...eduler/api/dto/schedule/ScheduleFilterRequest.java 0.00% <0.00%> (ø)
...eduler/api/dto/workflow/WorkflowCreateRequest.java 100.00% <ø> (ø)
...eduler/api/dto/workflow/WorkflowFilterRequest.java 33.33% <ø> (ø)
...eduler/api/dto/workflow/WorkflowUpdateRequest.java 50.00% <ø> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <ø> (ø)
...rg/apache/dolphinscheduler/api/k8s/K8sManager.java 58.53% <ø> (ø)
...che/dolphinscheduler/alert/AlertSenderService.java 46.00% <5.26%> (-3.65%) ⬇️
... and 187 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

aiwenmo and others added 29 commits October 12, 2022 19:02
…12256)

Co-authored-by: wenmo <32723967+wenmo@users.noreply.github.com>
* Set up UI setting component in profile page

* Add UI setting page to the route, remove UI setting section from the profile

* Add log auto refresh timer store

* Add logTimer to pinia store and cookies

* Read logTimer from pinia store, and delay getLogs by passing the logTimer to setInterval in refreshLogs function

* Add log timer to getLogs

* Fine tune view log, add auto refresh based on time interval set in UI setting

* Add useI18n to ui setting

* Set up UI setting component in profile page

* Add UI setting page to the route, remove UI setting section from the profile

* Add log auto refresh timer store

* Add logTimer to pinia store and cookies

* Read logTimer from pinia store, and delay getLogs by passing the logTimer to setInterval in refreshLogs function

* Add log timer to getLogs

* Fine tune view log, add auto refresh based on time interval set in UI setting

* Add useI18n to ui setting

* [Feat][UI] Add UI setting page in the project.

* [Feat][UI] Add UI setting page in the project.

* Remove logTimer in cookies

* Clear timer id, set VITE_APP_DEV_WEB_URL back to default

* Clear time id in dag

* [Feat][UI] Add license header.

* [Feat][UI] Remove console.

* [Fix][UI] Fix log timer types.

Co-authored-by: songjianet <1778651752@qq.com>
* submit datasync task

* add aws software package license
#12152)

* [DS-12131][master] Optimize the log printing of the master module according to the log specification.
delete software.amazon.awssdk datasync useless dependency exclusions
…e project (#12244)

* Fully remove the usage of powermock from the whole project

* Upgrade org.reflections to 0.10.12
* create oracle help.md

* Add files via upload

allow Oracle to choose schema

* move pic under img and add title for oracle.md
…are not triggered on time (#12233)

Co-authored-by: fan.wang <fan.wang@jiduauto.com>
To make our release process easier, I plan to mark milestone
and label is required before the PR merged, they use for

* label: In this path we required label with at least on with
  'feature|bug|improvement|document|chore' to make our changelog
  more convenient
* milestone: For easier to cherry-pick PR, currently some of
  our milestone only exists in issue and not exists in related
  PR, it may
Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>
…o v3.0.0 ,such as file cannot be found or column not found etc (#11619)

* fix the bugs which upgrade ds metabase from v1.3.9 to v3.0.0 with mysql

* [Fix-11590][upgrade] Fix the bugs when I upgrade ds from v1.3.9 to v3.0.0 ,such as file cannot be found or column not found etc

* fix: #11590 add process_instance_code_state_index with table t_ds_process_instance to improve query efficiency for the method of findLastProcessInterval

* Fix the bug  that cannot find the files when upgrade ds version with postgresql

Co-authored-by: fan.wang <fan.wang@jiduauto.com>
Co-authored-by: fanwanlong <fanwanlong@kezaihui.com>
…k-plugin module as an example (#12299)

* Migrate all UT cases from jUnit4 to jUnit5 in task-plugin module as an example
…ge (#12108)

Co-authored-by: jegger <zhangbq3306@163.com>
Add script for  easier release including cherry pick,
generating changelog and contributor list

* Auto cherry-pick: `python release.py cherry-pick`
* Generate changelog: `python release.py changelog`
* Generate contributor: `python release.py contributor`

close: #11289
related: #12222
ref: #11478 we already have a new tool for releasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend CI&CD document e2e e2e test first time contributor First-time contributor improvement make more easy to user or prompt friendly Pyscheduler test UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] [Kubernetes] After deploying DolphinScheduler with kubernetes, some problems are encountered in the use process.