[Improvement][Master] Add Worker Group validator in api side.#12051
Closed
DarkAssassinator wants to merge 15 commits intoapache:devfrom
Closed
[Improvement][Master] Add Worker Group validator in api side.#12051DarkAssassinator wants to merge 15 commits intoapache:devfrom
DarkAssassinator wants to merge 15 commits intoapache:devfrom
Conversation
…find the worker group. apache#12001
DarkAssassinator
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #12051 +/- ##
=========================================
Coverage 38.65% 38.66%
- Complexity 4005 4006 +1
=========================================
Files 1002 1002
Lines 37213 37219 +6
Branches 4249 4250 +1
=========================================
+ Hits 14386 14390 +4
- Misses 21195 21196 +1
- Partials 1632 1633 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
ruanwenjun
requested changes
Sep 20, 2022
...src/main/java/org/apache/dolphinscheduler/server/master/runner/task/CommonTaskProcessor.java
Outdated
Show resolved
Hide resolved
DarkAssassinator
requested review from
ruanwenjun
and removed request for
SbloodyS and
caishunfeng
Contributor
|
Hi @DarkAssassinator please use the correct title, thanks~ |
DarkAssassinator
changed the title
Contributor
Author
ohh. so sorry. done |
ruanwenjun
reviewed
Sep 23, 2022
...uler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
* [feat] New restful API for workflow and schedule CURD for workflow and schedule, different with exists API, this new restful api only operate single resource in each request, and return the latest. For example, previous workflow should also need to post tasks definition and tasks relation definition, but this patch will allow you to create workflow without task relate information * use checkProjectAndAuthThrowException, and fix CI error * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ScheduleV2Controller.java * change method name from createProcessDefinitionV2 to createSingleProcessDefinition from updateProcessDefinitionV2 to updateSingleProcessDefinition Co-authored-by: caishunfeng <caishunfeng2021@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+358
to
+360
| long subProcessCode = Long | ||
| .parseLong(JSONUtils.getNodeString(taskDefinition.getTaskParams(), | ||
| Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE)); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
…ta complement (apache#12121) * Add instructions for process execution type and data complement * Fix and polish the docs
…che#12050) * [Bug] [Master] Cannot remove the WorkerGroup from the master service. apache#12000 * remove unnecessary locks * Update dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java Co-authored-by: caishunfeng <caishunfeng2021@gmail.com> Co-authored-by: caishunfeng <caishunfeng2021@gmail.com>
…ultiple sql statements (apache#11292)
…y, the email fails to send the attachment, and an exception will be reported (apache#12059) * [Bug-apache#12057][task-plugin] fix when the sql query result is empty, the email fails to send the attachment, and an exception will be reported Co-authored-by: 冯剑 Jian <jian.feng@jiduauto.com>
DarkAssassinator
requested review from
EricGao888,
Tianqi-Dotes and
zhongjiajie
as code owners
Contributor
Author
|
Misuse coverage in conflict resolution， close it and re-open |
Comment on lines
+386
to
+388
| taskDefinition -> processDefinitionCodeSet.add(Long.valueOf( | ||
| JSONUtils.getNodeString(taskDefinition.getTaskParams(), | ||
| Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE)))); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #12001
Brief change log
Just add a validator before task instance was put to dispatch queue.
Why need this change?
Because check the worker group before add to dispatch queue can avoid invalid infinite loops in
TaskPriorityQueueConsumerVerify this pull request