Skip to content

[Fix] [Bug] Fix bugs such as missing status and workflow when creating and modifying task definitions#12100

Closed
jinyanhui2008 wants to merge 6 commits intoapache:3.0.1-releasefrom
jinyanhui2008:3.0.1-release-#11952
Closed

[Fix] [Bug] Fix bugs such as missing status and workflow when creating and modifying task definitions#12100
jinyanhui2008 wants to merge 6 commits intoapache:3.0.1-releasefrom
jinyanhui2008:3.0.1-release-#11952

Conversation

@jinyanhui2008
Copy link
Copy Markdown
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@jinyanhui2008 jinyanhui2008 changed the title [Fix] [Bug] Fix bugs such as missing status and workflow when creating and modifying task definitions #11952 [Fix] [Bug] Fix bugs such as missing status and workflow when creating and modifying task definitions Sep 22, 2022
@caishunfeng
Copy link
Copy Markdown
Contributor

@jinyanhui2008 please add some description of this pr.

Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the front-end code just for debug, please remove these changes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (3.0.1-release@b3c27ef). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             3.0.1-release   #12100   +/-   ##
================================================
  Coverage                 ?   39.86%           
  Complexity               ?     4581           
================================================
  Files                    ?      888           
  Lines                    ?    35166           
  Branches                 ?     3873           
================================================
  Hits                     ?    14018           
  Misses                   ?    19788           
  Partials                 ?     1360           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 6 Bugs
Vulnerability E 6 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 246 Code Smells

39.5% 39.5% Coverage
9.4% 9.4% Duplication

@jinyanhui2008
Copy link
Copy Markdown
Contributor Author

Repair task definition function:

  1. Modification of task definition may lead to loss of workflow definition and status

  2. Missing predecessors when modifying task definitions

  3. Creating and modifying task definitions will lose workflow definitions of other task definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants