[Improvement][Master]add worker group checking steps before workflow executor#12136
[Improvement][Master]add worker group checking steps before workflow executor#12136DarkAssassinator wants to merge 2 commits intoapache:devfrom
Conversation
|
@caishunfeng @SbloodyS could u help to review this PR? thx |
hstdream
left a comment
There was a problem hiding this comment.
List<String> availableWorkerGroupList = workerGroups.stream() .map(WorkerGroup::getName) .collect(Collectors.toList()); if (!availableWorkerGroupList.contains(Constants.DEFAULT_WORKER_GROUP)) { availableWorkerGroupList.add(Constants.DEFAULT_WORKER_GROUP); }
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Show resolved
Hide resolved
99b8bae to
80ba0ee
Compare
Codecov Report
@@ Coverage Diff @@
## dev #12136 +/- ##
============================================
- Coverage 39.70% 39.70% -0.01%
- Complexity 4190 4195 +5
============================================
Files 1016 1016
Lines 38049 38090 +41
Branches 4365 4371 +6
============================================
+ Hits 15108 15124 +16
- Misses 21196 21219 +23
- Partials 1745 1747 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
ruanwenjun
left a comment
There was a problem hiding this comment.
I prefer we can set the task to fail if it cannot find the workGroup, rather than check the workgroup, since the workflow may be executed by the scheduler rather than manual.
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |








Purpose of the pull request
fix #12001
Brief change log
Just add a validator before task instance was put to dispatch queue.
Verify this pull request