Skip to content

[Fix-12214] Fix oracle can't choose schema#12216

Closed
Chris-playground wants to merge 1 commit intoapache:devfrom
Chris-playground:dev
Closed

[Fix-12214] Fix oracle can't choose schema#12216
Chris-playground wants to merge 1 commit intoapache:devfrom
Chris-playground:dev

Conversation

@Chris-playground
Copy link
Contributor

Purpose of the pull request

fix bug #12214

Brief change log

oracle can only use the default database, we can't choose databases

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Chris-playground Chris-playground closed this by deleting the head repository Sep 29, 2022
@SbloodyS SbloodyS added the first time contributor First-time contributor label Oct 5, 2022
@SbloodyS SbloodyS added this to the 3.0.2 milestone Oct 5, 2022
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@SbloodyS SbloodyS changed the title fix oracle can't choose schema [Fix-12214] Fix oracle can't choose schema Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #12216 (7af7e30) into dev (1a4d7a8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #12216      +/-   ##
============================================
- Coverage     39.44%   39.43%   -0.02%     
+ Complexity     4142     4139       -3     
============================================
  Files          1011     1011              
  Lines         37845    37847       +2     
  Branches       4345     4348       +3     
============================================
- Hits          14929    14926       -3     
- Misses        21185    21190       +5     
  Partials       1731     1731              
Impacted Files Coverage Δ
...eduler/api/service/impl/DataSourceServiceImpl.java 29.87% <0.00%> (-0.19%) ⬇️
.../org/apache/dolphinscheduler/common/Constants.java 78.26% <ø> (ø)
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

26.3% 26.3% Coverage
0.0% 0.0% Duplication

@Chris-playground
Copy link
Contributor Author

I'll submit a new PR.

@EricGao888 EricGao888 removed this from the 3.0.2 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants