[fix#12257][Data Quality] Fix no main class set in JAR #12310
Closed
pandong2011 wants to merge 13 commits intoapache:devfrom
pandong2011:fix-no-main-class
Closed
[fix#12257][Data Quality] Fix no main class set in JAR #12310pandong2011 wants to merge 13 commits intoapache:devfrom pandong2011:fix-no-main-class
pandong2011 wants to merge 13 commits intoapache:devfrom
pandong2011:fix-no-main-class
Conversation
…s during Python task execution
…s during Python task execution
…elated files during Python task execution
# Conflicts: # dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/test/java/org/apache/dolphinscheduler/plugin/task/api/parser/TimePlaceholderUtilsTest.java
pandong2011
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
|
How about set main class in maven build |
|
Quick fix:
|
Contributor
Author
I don't recommend doing this, because if you rebuild, you have to change this file every time. If you want to use maven, I recommend overwriting shade or jar plug-ins in the pom.xml and adding the corresponding configuration, but this implementation is not readable or maintainable |
|
Yes, this is not a good idea. Just use in case the release not public |
Member
|
Hi @pandong2011 are this issue in version 3.0.x or version 3.1.x? |
Member
|
@pandong2011 can you test latest code? it should work |
Member
|
Close by #13360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #12257
Brief change log
Verify this pull request
Manually verified the change by testing locally