Skip to content

[ci] Add path filter for CodeQL#12326

Closed
zhongjiajie wants to merge 1 commit intoapache:devfrom
zhongjiajie:i-ci-path-filter
Closed

[ci] Add path filter for CodeQL#12326
zhongjiajie wants to merge 1 commit intoapache:devfrom
zhongjiajie:i-ci-path-filter

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

Add new rule for CodeQL, All src directory
except pydolphinscheduler/src

Add new rule for CodeQL, All `src` directory
except `pydolphinscheduler/src`
@zhongjiajie zhongjiajie self-assigned this Oct 12, 2022
@zhongjiajie zhongjiajie added this to the 3.0.2 milestone Oct 12, 2022
@zhongjiajie zhongjiajie added the minor Chore Chores about the project, like code clean, typo, etc. label Oct 12, 2022
Comment on lines +45 to +46
- 'src/**'
- '!(pydolphinscheduler/src/**)'
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether it work or not

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #12326 (d52d4e4) into dev (308f632) will decrease coverage by 0.94%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12326      +/-   ##
============================================
- Coverage     39.54%   38.59%   -0.95%     
+ Complexity     4176     4098      -78     
============================================
  Files          1016     1031      +15     
  Lines         38090    38459     +369     
  Branches       4376     4404      +28     
============================================
- Hits          15062    14843     -219     
- Misses        21287    21887     +600     
+ Partials       1741     1729      -12     
Impacted Files Coverage Δ
.../apache/dolphinscheduler/rpc/client/RpcClient.java 0.00% <0.00%> (-100.00%) ⬇️
...che/dolphinscheduler/rpc/protocol/RpcProtocol.java 0.00% <0.00%> (-100.00%) ⬇️
...e/dolphinscheduler/rpc/client/RpcRequestCache.java 0.00% <0.00%> (-100.00%) ⬇️
...e/dolphinscheduler/rpc/protocol/MessageHeader.java 0.00% <0.00%> (-100.00%) ⬇️
...dolphinscheduler/rpc/common/ThreadPoolManager.java 0.00% <0.00%> (-100.00%) ⬇️
...dolphinscheduler/rpc/serializer/RpcSerializer.java 0.00% <0.00%> (-100.00%) ⬇️
...lphinscheduler/rpc/common/AbstractRpcCallBack.java 0.00% <0.00%> (-100.00%) ⬇️
...pache/dolphinscheduler/rpc/codec/NettyEncoder.java 0.00% <0.00%> (-93.75%) ⬇️
...he/dolphinscheduler/rpc/client/ConsumerConfig.java 0.00% <0.00%> (-90.91%) ⬇️
...pache/dolphinscheduler/rpc/protocol/EventType.java 0.00% <0.00%> (-90.00%) ⬇️
... and 94 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

cancel-in-progress: true

jobs:
paths-filter:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work in push event, when pushing to dev branch, CodeQL must be run and it acts as a basis for those runs in pull requests

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean we should also run CodeQL although we also have docs change in our PR?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean we should also run CodeQL although we also have docs change in our PR?

I mean we need to always run CodeQL in dev branch.

@EricGao888 EricGao888 modified the milestones: 3.0.2, 3.2.0 Nov 7, 2022
@zhongjiajie zhongjiajie closed this Mar 7, 2023
@zhongjiajie zhongjiajie deleted the i-ci-path-filter branch March 7, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI&CD minor Chore Chores about the project, like code clean, typo, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants