[Bug] Improve the scenario of continuing to submit subsequent tasks after failure#12448
Closed
WangJPLeo wants to merge 5 commits intoapache:devfrom
Closed
[Bug] Improve the scenario of continuing to submit subsequent tasks after failure#12448WangJPLeo wants to merge 5 commits intoapache:devfrom
WangJPLeo wants to merge 5 commits intoapache:devfrom
Conversation
WangJPLeo
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
WangJPLeo
changed the title
Comment on lines
+428
to
+435
| if (!DagHelper.haveAnyNodeAfterNode(Long.toString(taskInstance.getTaskCode()), dag)) { | ||
| submitPostNode(Long.toString(taskInstance.getTaskCode())); | ||
| } else { | ||
| if (taskInstance.isConditionsTask() | ||
| || DagHelper.haveConditionsAfterNode(Long.toString(taskInstance.getTaskCode()), dag)) { | ||
| submitPostNode(Long.toString(taskInstance.getTaskCode())); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
could we move these conditions to a private function or workflow util, such as shouldSubmitPostNode? because all these condition should submitPostNode, might be clearer for reading. WDYT.
Contributor
Author
There was a problem hiding this comment.
That's excellent, i will improve it.
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Improve the scenario of continuing to submit subsequent tasks after failure.
Brief change log
a. nodes are parallel;
b. nodes are serial and failed task type is condition;
c. nodes are serial and next task type is condition;
haveAllNodeAfterNodechange tohaveAnyNodeAfterNode;Verify this pull request
Manually verified the change by testing locally.