Skip to content

[Bug] Resource default auth function disabled false.#12467

Merged
zhuangchong merged 2 commits intoapache:devfrom
WangJPLeo:function-disabled-fix
Nov 6, 2022
Merged

[Bug] Resource default auth function disabled false.#12467
zhuangchong merged 2 commits intoapache:devfrom
WangJPLeo:function-disabled-fix

Conversation

@WangJPLeo
Copy link
Contributor

Purpose of the pull request

Resource auth function disable check fix.

Brief change log

Resource authorization repair disable logic.
fix #12466

Verify this pull request

Manually verified the change by testing locally.

@WangJPLeo WangJPLeo added the bug Something isn't working label Oct 20, 2022
@WangJPLeo WangJPLeo added this to the 3.1.1 milestone Oct 20, 2022
@DarkAssassinator
Copy link
Contributor

I thought this part was temporarily disable, because that’s what was expected in test case. So please update test case at the same time. WDYT

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #12467 (3c29a7e) into dev (70aef3e) will decrease coverage by 0.23%.
The diff coverage is 57.25%.

❗ Current head 3c29a7e differs from pull request most recent head 0f85568. Consider uploading reports for the commit 0f85568 to get more accurate results

@@             Coverage Diff              @@
##                dev   #12467      +/-   ##
============================================
- Coverage     39.38%   39.14%   -0.24%     
+ Complexity     4214     4208       -6     
============================================
  Files          1040     1045       +5     
  Lines         39158    39700     +542     
  Branches       4482     4571      +89     
============================================
+ Hits          15423    15542     +119     
- Misses        21958    22389     +431     
+ Partials       1777     1769       -8     
Impacted Files Coverage Δ
...in/alert/dingtalk/DingTalkAlertChannelFactory.java 98.79% <ø> (ø)
...cheduler/plugin/alert/dingtalk/DingTalkSender.java 34.91% <0.00%> (ø)
...r/plugin/alert/email/EmailAlertChannelFactory.java 98.82% <ø> (ø)
...olphinscheduler/plugin/alert/email/ExcelUtils.java 81.63% <ø> (ø)
...olphinscheduler/plugin/alert/email/MailSender.java 50.68% <ø> (ø)
...ugin/alert/email/template/DefaultHTMLTemplate.java 79.24% <ø> (ø)
...plugin/alert/feishu/FeiShuAlertChannelFactory.java 97.36% <ø> (ø)
...dolphinscheduler/plugin/alert/http/HttpSender.java 47.69% <ø> (ø)
...eduler/plugin/alert/pagerduty/PagerDutySender.java 66.07% <ø> (ø)
...eduler/plugin/alert/script/ScriptAlertChannel.java 16.66% <0.00%> (ø)
... and 257 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@zhuangchong zhuangchong added the 3.1.x for 3.1.x version label Nov 4, 2022
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.1.x for 3.1.x version backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Resource] Resource authorization is disabled

5 participants