[Improvement-12945][Tools] improvement: fix some sonarlint warning and file name spell error#12946
[Improvement-12945][Tools] improvement: fix some sonarlint warning and file name spell error#12946ZhongJinHacker wants to merge 9 commits intoapache:devfrom
Conversation
|
thanks for your first contribution to Apache DolphinScheduler, It makes a lot of sense,Looking forward to your deep participation this PR looks good to me. and please wait the CI check result |
...s/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyProcessDefinitionController.java
Outdated
Show resolved
Hide resolved
|
@ZhongJinHacker Could u plz run 'mvn spotless:apply' to fix formatting errors so that CI could pass? Thanks. |
…er/tools/demo/ProxyProcessDefinitionController.java Co-authored-by: Aaron Wang <wangweirao16@gmail.com>
|
@EricGao888 ok, I had run 'mvn spotless:apply' in my local PC today, evertything is ok, and then I had pushed the fixed code. please review again. thank you for your suggestion |
Codecov Report
@@ Coverage Diff @@
## dev #12946 +/- ##
============================================
- Coverage 39.31% 38.77% -0.55%
- Complexity 4247 4291 +44
============================================
Files 1061 1080 +19
Lines 40050 41384 +1334
Branches 4604 4706 +102
============================================
+ Hits 15746 16046 +300
- Misses 22524 23558 +1034
Partials 1780 1780
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fix |
|
@ZhongJinHacker Please add license header for two UT files. |
|
@Radeity fix, thank you |
|
I have add unit tests to fix unittest coverage problem. |
|
Kudos, SonarCloud Quality Gate passed! |
|
@EricGao888 @davidzollo could you merge this PR ? all checks have passed. I can't wait to do something for the next issue |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |









Purpose of the pull request
fix issue #12945
improvement : fix some sonarlint warning and file name spell error
Brief change log
please check the code diff
Verify this pull request
Manually verified the change by testing locally.