Skip to content

[Improvement-12945][Tools] improvement: fix some sonarlint warning and file name spell error#12946

Closed
ZhongJinHacker wants to merge 9 commits intoapache:devfrom
ZhongJinHacker:dev20221119
Closed

[Improvement-12945][Tools] improvement: fix some sonarlint warning and file name spell error#12946
ZhongJinHacker wants to merge 9 commits intoapache:devfrom
ZhongJinHacker:dev20221119

Conversation

@ZhongJinHacker
Copy link
Contributor

@ZhongJinHacker ZhongJinHacker commented Nov 19, 2022

Purpose of the pull request

fix issue #12945

improvement : fix some sonarlint warning and file name spell error

Brief change log

please check the code diff

Verify this pull request

Manually verified the change by testing locally.

@ZhongJinHacker ZhongJinHacker changed the title [Improvement-12945][Tools] fix some sonarlint warning and file name spell error [Improvement-12945][Tools] improvement: fix some sonarlint warning and file name spell error Nov 19, 2022
@davidzollo davidzollo added the first time contributor First-time contributor label Nov 20, 2022
@davidzollo
Copy link
Contributor

thanks for your first contribution to Apache DolphinScheduler, It makes a lot of sense,Looking forward to your deep participation

this PR looks good to me. and please wait the CI check result

@davidzollo davidzollo added improvement make more easy to user or prompt friendly 3.1.x for 3.1.x version labels Nov 20, 2022
EricGao888
EricGao888 previously approved these changes Nov 20, 2022
@EricGao888
Copy link
Member

@ZhongJinHacker Could u plz run 'mvn spotless:apply' to fix formatting errors so that CI could pass? Thanks.

@EricGao888 EricGao888 added this to the 3.2.0 milestone Nov 20, 2022
@EricGao888 EricGao888 added 3.2.0 for 3.2.0 version and removed 3.1.x for 3.1.x version labels Nov 20, 2022
…er/tools/demo/ProxyProcessDefinitionController.java

Co-authored-by: Aaron Wang <wangweirao16@gmail.com>
@ZhongJinHacker
Copy link
Contributor Author

ZhongJinHacker commented Nov 21, 2022

@EricGao888 ok, I had run 'mvn spotless:apply' in my local PC today, evertything is ok, and then I had pushed the fixed code. please review again. thank you for your suggestion
dpsder001

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #12946 (f7d9585) into dev (27c37b8) will decrease coverage by 0.54%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                dev   #12946      +/-   ##
============================================
- Coverage     39.31%   38.77%   -0.55%     
- Complexity     4247     4291      +44     
============================================
  Files          1061     1080      +19     
  Lines         40050    41384    +1334     
  Branches       4604     4706     +102     
============================================
+ Hits          15746    16046     +300     
- Misses        22524    23558    +1034     
  Partials       1780     1780              
Impacted Files Coverage Δ
...uler/tools/datasource/DolphinSchedulerManager.java 0.00% <0.00%> (ø)
...pache/dolphinscheduler/tools/demo/ProxyResult.java 50.00% <0.00%> (ø)
...hinscheduler/tools/demo/ProcessDefinitionDemo.java 41.16% <75.00%> (ø)
...che/dolphinscheduler/tools/demo/DemoConstants.java 100.00% <100.00%> (ø)
...r/tools/demo/ProxyProcessDefinitionController.java 88.88% <100.00%> (ø)
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...olphinscheduler/plugin/task/python/PythonTask.java 9.72% <0.00%> (-0.14%) ⬇️
...erver/master/runner/WorkflowExecuteThreadPool.java 1.20% <0.00%> (-0.02%) ⬇️
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ZhongJinHacker
Copy link
Contributor Author

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 1 Code Smell

0.0% 0.0% Coverage 0.0% 0.0% Duplication

fix

@ZhongJinHacker ZhongJinHacker requested review from EricGao888 and removed request for SbloodyS, caishunfeng and zhongjiajie November 21, 2022 11:02
@ZhongJinHacker ZhongJinHacker requested review from EricGao888 and Radeity and removed request for EricGao888 and Radeity November 21, 2022 11:02
@ZhongJinHacker ZhongJinHacker requested review from Radeity and removed request for EricGao888 November 22, 2022 10:55
Radeity
Radeity previously approved these changes Nov 22, 2022
@Radeity
Copy link
Member

Radeity commented Nov 23, 2022

@ZhongJinHacker Please add license header for two UT files.

@ZhongJinHacker
Copy link
Contributor Author

@Radeity fix, thank you

@ZhongJinHacker
Copy link
Contributor Author

ZhongJinHacker commented Nov 26, 2022

I have add unit tests to fix unittest coverage problem.
tips: some source code is hard to write unit test like DolphinSchedulerManager.java which need a real database datasource access in its constuctor method. It needs overrload a new constuctor method for DolphinSchedulerManager.
@EricGao888

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.5% 61.5% Coverage
0.0% 0.0% Duplication

@ZhongJinHacker
Copy link
Contributor Author

@EricGao888 @davidzollo could you merge this PR ? all checks have passed. I can't wait to do something for the next issue

@ZhongJinHacker ZhongJinHacker requested review from EricGao888 and Radeity and removed request for EricGao888 and Radeity December 20, 2022 10:22
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jun 9, 2023
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.0 for 3.2.0 version backend first time contributor First-time contributor improvement make more easy to user or prompt friendly priority:middle Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants