Skip to content

Update dolphinscheduler_ddl.sql for mysql#13080

Closed
darrkz wants to merge 2 commits intoapache:devfrom
darrkz:patch-4
Closed

Update dolphinscheduler_ddl.sql for mysql#13080
darrkz wants to merge 2 commits intoapache:devfrom
darrkz:patch-4

Conversation

@darrkz
Copy link
Contributor

@darrkz darrkz commented Dec 2, 2022

Speed Up delete process from Web UI #12826

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Speed Up delete process from Web UI apache#12826
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #13080 (b6b4a88) into dev (1192720) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #13080   +/-   ##
=========================================
  Coverage     39.22%   39.22%           
  Complexity     4275     4275           
=========================================
  Files          1069     1069           
  Lines         40311    40311           
  Branches       4634     4634           
=========================================
+ Hits          15812    15814    +2     
+ Misses        22722    22718    -4     
- Partials       1777     1779    +2     
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 69.64% <0.00%> (-10.72%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 50.00% <0.00%> (+6.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@darrkz darrkz changed the title Update dolphinscheduler_ddl.sql Update dolphinscheduler_ddl.sql for mysql Dec 2, 2022
delimiter ;
CALL uc_dolphin_T_t_ds_task_instance_R_test_flag;
DROP PROCEDURE uc_dolphin_T_t_ds_task_instance_R_test_flag;
alter table t_ds_task_instance add index idx_task_instance_process_instance_flag(process_instance_id, flag);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alter table t_ds_task_instance add index idx_task_instance_process_instance_flag(process_instance_id, flag);
alter table t_ds_task_instance add index idx_task_instance_process_instance_flag(process_instance_id, flag);

@EricGao888
Copy link
Member

#12826 (comment)

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ruanwenjun ruanwenjun closed this Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants