Skip to content

Fix the invalidate task instance never be deleted.#13091

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixDeleteTaskInstance
Dec 4, 2022
Merged

Fix the invalidate task instance never be deleted.#13091
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixDeleteTaskInstance

Conversation

@ruanwenjun
Copy link
Member

close #12826

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added bug Something isn't working 3.1.x for 3.1.x version 3.0.x labels Dec 4, 2022
@ruanwenjun ruanwenjun modified the milestones: 3.0.3, 3.0.4 Dec 4, 2022
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun changed the title Delete task instance by workflow instanceId don't need to query Fix the invalidate task instance never be deleted. Dec 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #13091 (d68348b) into dev (fa3e2a5) will increase coverage by 0.02%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##                dev   #13091      +/-   ##
============================================
+ Coverage     39.20%   39.22%   +0.02%     
- Complexity     4273     4276       +3     
============================================
  Files          1069     1069              
  Lines         40311    40301      -10     
  Branches       4634     4628       -6     
============================================
+ Hits          15804    15810       +6     
+ Misses        22729    22713      -16     
  Partials       1778     1778              
Impacted Files Coverage Δ
...duler/dao/repository/impl/TaskInstanceDaoImpl.java 3.44% <0.00%> (-0.13%) ⬇️
...nscheduler/service/process/ProcessServiceImpl.java 29.74% <ø> (+0.27%) ⬆️
...r/api/service/impl/ProcessInstanceServiceImpl.java 64.09% <33.33%> (+0.12%) ⬆️
...erver/master/processor/queue/TaskEventService.java 80.35% <0.00%> (+10.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit fed1e85 into apache:dev Dec 4, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixDeleteTaskInstance branch December 4, 2022 10:38
@zhongjiajie zhongjiajie removed the 3.0.x label Dec 28, 2022
@zhongjiajie
Copy link
Member

The diff between this patch to 3.0.4-prepare is too large, remove label 3.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.1.x for 3.1.x version backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants