Skip to content

[improve-#13058]when task instance host is null,return friendly message#13093

Closed
fuchanghai wants to merge 3 commits intoapache:devfrom
fuchanghai:improve-#13058
Closed

[improve-#13058]when task instance host is null,return friendly message#13093
fuchanghai wants to merge 3 commits intoapache:devfrom
fuchanghai:improve-#13058

Conversation

@fuchanghai
Copy link
Member

Purpose of the pull request

when task instance host is null,return friendly message

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

this close : #13058

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #13093 (3c248c3) into dev (fed1e85) will increase coverage by 0.14%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##                dev   #13093      +/-   ##
============================================
+ Coverage     39.21%   39.35%   +0.14%     
- Complexity     4273     4303      +30     
============================================
  Files          1069     1069              
  Lines         40301    40829     +528     
  Branches       4632     4837     +205     
============================================
+ Hits          15804    16069     +265     
- Misses        22719    22968     +249     
- Partials       1778     1792      +14     
Impacted Files Coverage Δ
...nscheduler/api/service/impl/LoggerServiceImpl.java 69.11% <20.00%> (-3.20%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
...duler/api/controller/TaskDefinitionController.java 2.38% <0.00%> (-0.40%) ⬇️
...duler/dao/repository/impl/TaskInstanceDaoImpl.java 3.38% <0.00%> (-0.06%) ⬇️
.../server/master/runner/StateWheelExecuteThread.java 0.40% <0.00%> (+<0.01%) ⬆️
...apache/dolphinscheduler/service/log/LogClient.java 41.07% <0.00%> (+0.07%) ⬆️
...dolphinscheduler/remote/future/ResponseFuture.java 83.60% <0.00%> (+1.63%) ⬆️
...nscheduler/service/process/ProcessServiceImpl.java 31.80% <0.00%> (+2.06%) ⬆️
...r/api/service/impl/ProcessInstanceServiceImpl.java 66.72% <0.00%> (+2.63%) ⬆️
...er/api/service/impl/TaskDefinitionServiceImpl.java 35.84% <0.00%> (+5.96%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that in some situations, the task host is null? In that case, the original message makes sense to me.

@EricGao888 EricGao888 added the improvement make more easy to user or prompt friendly label Dec 5, 2022
…/api/enums/Status.java


thx

Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
@fuchanghai fuchanghai closed this Dec 6, 2022
@fuchanghai fuchanghai reopened this Dec 6, 2022
@fuchanghai fuchanghai closed this Dec 8, 2022
@fuchanghai fuchanghai reopened this Dec 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@fuchanghai
Copy link
Member Author

Is it possible that in some situations, the task host is null? In that case, the original message makes sense to me.

@caishunfeng @SbloodyS PTAL

@SbloodyS
Copy link
Member

Is it possible that in some situations, the task host is null? In that case, the original message makes sense to me.

It is possible in some unusual scenarios.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label May 20, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Jun 6, 2023
@fuchanghai fuchanghai deleted the improve-#13058 branch October 28, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][LOG] When worker resources are not enough.query log will throw exception task instance host is null

4 participants