Skip to content

Feature 13165#13327

Closed
mxq-151 wants to merge 9 commits intoapache:devfrom
mxq-151:feature-13165
Closed

Feature 13165#13327
mxq-151 wants to merge 9 commits intoapache:devfrom
mxq-151:feature-13165

Conversation

@mxq-151
Copy link

@mxq-151 mxq-151 commented Jan 3, 2023

Purpose of the pull request

this pr is for issue #13165

Brief change log

1.change rest api in dolphinscheduler-api
2.change mapper in dolphinscheduler-dao
3.add some field mysql table
4.add code in OssOperator

1.add user view
image

2.project admin view
image

3.admin user's resource view
image

4.admin user's project view
image

5.admin user's run-job view
image

6.project user' run-job view
image

@github-actions github-actions bot added backend UI ui and front end related labels Jan 3, 2023
@SbloodyS SbloodyS linked an issue Jan 3, 2023 that may be closed by this pull request
3 tasks
@SbloodyS SbloodyS added the 3.2.0 for 3.2.0 version label Jan 3, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jan 3, 2023
@SbloodyS SbloodyS added feature new feature miss:docs missing documents in PR labels Jan 3, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the document too.

@SbloodyS SbloodyS added the first time contributor First-time contributor label Jan 3, 2023
@mxq-151
Copy link
Author

mxq-151 commented Jan 3, 2023

Please update the document too.

I will do it later,would you guys merge this pr without doc?

@SbloodyS
Copy link
Member

SbloodyS commented Jan 3, 2023

Please update the document too.

I will do it later,would you guys merge this pr without doc?

It is better to merge with the document.

@mxq-151
Copy link
Author

mxq-151 commented Jan 4, 2023

i found authority management have been commited,it is too coarse,it's hard to use,now should i conitnue to update doc to commit this pr?
image

@mxq-151
Copy link
Author

mxq-151 commented Jan 4, 2023

i found authority management have been commited,it is too coarse,it's hard to use,now should i conitnue to update doc to commit this pr? image

@SbloodyS some case in use as below
1.Certain users can only access certain workers
2.it cost too much tell admin user to config alert group,alert group should manager by tenant it selft
3.it's dangerous that someone has permission to run a job(who has edit permission can run a job too)

@SbloodyS
Copy link
Member

SbloodyS commented Jan 4, 2023

i found authority management have been commited,it is too coarse,it's hard to use,now should i conitnue to update doc to commit this pr?

You can optimize the document in this PR, or you can create a separate PR. The main purpose is that new features need to be consistent in code and documentation.

@mxq-151
Copy link
Author

mxq-151 commented Jan 4, 2023

i found authority management have been commited,it is too coarse,it's hard to use,now should i conitnue to update doc to commit this pr?

You can optimize the document in this PR, or you can create a separate PR. The main purpose is that new features need to be consistent in code and documentation.

ok,docs will update soon

@zhongjiajie
Copy link
Member

Hi @mxq-151 I personally do not thing OSS project should have complex permission setting, unless the project is design for permission configurations, because each person or company have it own permission need, maybe some config we thing is useful is useless for others.

and unless we make our permission config as complete as possible, to allow user can config whatever they want, but it will cost lots of time to build and test it. And our code base will full of permission code, when user want to add new feature will be difficult

@mxq-151
Copy link
Author

mxq-151 commented Jan 4, 2023

Hi @mxq-151 I personally do not thing OSS project should have complex permission setting, unless the project is design for permission configurations, because each person or company have it own permission need, maybe some config we thing is useful is useless for others.

and unless we make our permission config as complete as possible, to allow user can config whatever they want, but it will cost lots of time to build and test it. And our code base will full of permission code, when user want to add new feature will be difficult

it means that you guys will not accept the pr?

@zhongjiajie
Copy link
Member

we need more discussions to judge whether we should accept or not. and maybe we will take some of them, or maybe we will merge all of them, but the point is more dicussions

@mxq-151
Copy link
Author

mxq-151 commented Jan 4, 2023

Hi @mxq-151 I personally do not thing OSS project should have complex permission setting, unless the project is design for permission configurations, because each person or company have it own permission need, maybe some config we thing is useful is useless for others.

and unless we make our permission config as complete as possible, to allow user can config whatever they want, but it will cost lots of time to build and test it. And our code base will full of permission code, when user want to add new feature will be difficult

What I have done is to delegate some authority to the project administrator to reduce the management cost of the super administrator, which should not be complicated

@mxq-151
Copy link
Author

mxq-151 commented Jan 4, 2023

docs have been updated(only chinese language),path:docs/docs/zh/guide/authority.md

@mergeable
Copy link

mergeable bot commented Jan 4, 2023

⚠️ This PR do not change database DDL synchronize.

@mxq-151
Copy link
Author

mxq-151 commented Jan 5, 2023

we need more discussions to judge whether we should accept or not. and maybe we will take some of them, or maybe we will merge all of them, but the point is more dicussions

@SbloodyS
how is going about the disccussion now?

@mxq-151
Copy link
Author

mxq-151 commented Jan 28, 2023

has any advise about this feature? @SbloodyS

@mxq-151 mxq-151 closed this by deleting the head repository Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.0 for 3.2.0 version backend discussion discussion document feature new feature first time contributor First-time contributor miss:docs missing documents in PR UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][dolphinschedule-api] fine-grained authority management

3 participants