[Feature][Registry] Add DS K8S registry plugin#13458
[Feature][Registry] Add DS K8S registry plugin#13458EricGao888 wants to merge 1 commit intoapache:devfrom
Conversation
EricGao888
added
feature
EricGao888
changed the title
EricGao888
force-pushed
the
Feature-13445
branch
from
efe6fba to
7c5a627
Compare
|
Action Items:
|
Codecov Report
@@ Coverage Diff @@
## dev #13458 +/- ##
============================================
- Coverage 39.56% 39.54% -0.03%
- Complexity 4337 4346 +9
============================================
Files 1086 1095 +9
Lines 40958 41113 +155
Branches 4697 4694 -3
============================================
+ Hits 16206 16259 +53
- Misses 22949 23048 +99
- Partials 1803 1806 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private final Map<String, Watch> watcherMap = new ConcurrentHashMap<>(); | ||
|
|
||
| private static final long TIME_TO_LIVE_SECONDS = 30L; | ||
| public KubernetesRegistry(KubernetesProperties registryProperties) { |
Check notice
Code scanning / CodeQL
Useless parameter
| public Collection<String> children(String key) { | ||
| // Make sure the string end with '/' | ||
| // eg:change key = /nodes to /nodes/ | ||
| String prefix = key.endsWith(FOLDER_SEPARATOR) ? key : key + FOLDER_SEPARATOR; |
Check notice
Code scanning / CodeQL
Unread local variable
|
SonarCloud Quality Gate failed. |
|
|
||
| @Data | ||
| @Configuration | ||
| @ConditionalOnProperty(prefix = "registry", name = "type", havingValue = "k8s") |
There was a problem hiding this comment.
I prefer we use the complete form
| @ConditionalOnProperty(prefix = "registry", name = "type", havingValue = "k8s") | |
| @ConditionalOnProperty(prefix = "registry", name = "type", havingValue = "kubernetes") |
There was a problem hiding this comment.
Sure, I will change it.
| private String namespace = "dolphinscheduler"; | ||
| private Duration connectionTimeout = Duration.ofSeconds(9); | ||
|
|
||
| // TODO: add rbac related config |
There was a problem hiding this comment.
Hi, I don't think we need this, I believe kubernetes registry plugin must be used when DolphinScheduler itself is deployed inside kubernetes, so we should add the rbac in our helm chart and we can assume it has sufficient permissions to access the needed resources, so no extra configurations are needed here
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
4 participants
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md