Skip to content

[fix-13515][DAO] fix the problems of the sql upgradation script in 3.2.0 schema.#13516

Closed
xxjingcd wants to merge 1 commit intoapache:devfrom
xxjingcd:Bug-13515
Closed

[fix-13515][DAO] fix the problems of the sql upgradation script in 3.2.0 schema.#13516
xxjingcd wants to merge 1 commit intoapache:devfrom
xxjingcd:Bug-13515

Conversation

@xxjingcd
Copy link
Contributor

@xxjingcd xxjingcd commented Feb 6, 2023

Purpose of the pull request

Fix the problems of the sql upgradation script in 3.2.0 schema.
This closes #13515

Brief change log

modify dolphinscheduler_postgresql.sql in 3.2.0_schema directory, the brief change is as follow:

Verify this pull request

  • create DS database using 3.1.x schema.
  • upgrade DB:execute dolphinscheduler_postgresql.sql in 3.2.0_schema directory;
  • Use the upgraded database to run version 3.2.0 DS.

I have upgraded the DB from 3.1.4 schema to 3.2.0 schema, created the process, and ran the process to verify.

@xxjingcd
Copy link
Contributor Author

xxjingcd commented Feb 6, 2023

About the delimiter syntax in pgsql

There is no delimiter syntax in pgsql function or storage procedure, and also no need for user to do that. For more, please refer to the discussion:Easy way of changing the delimiter in postgreSQL.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #13516 (e504873) into dev (8fa90c2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #13516      +/-   ##
============================================
- Coverage     39.60%   39.59%   -0.01%     
+ Complexity     4355     4353       -2     
============================================
  Files          1097     1097              
  Lines         41161    41161              
  Branches       4715     4715              
============================================
- Hits          16300    16298       -2     
  Misses        23048    23048              
- Partials       1813     1815       +2     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.08% <0.00%> (-0.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@xxjingcd xxjingcd changed the title [fix-13515][*] fix the problems of the sql upgradation script in 3.2.0 schema. [fix-13515][DAO] fix the problems of the sql upgradation script in 3.2.0 schema. Feb 6, 2023
@EricGao888 EricGao888 self-requested a review February 7, 2023 02:36
@EricGao888 EricGao888 added bug Something isn't working 3.2.0 for 3.2.0 version labels Feb 7, 2023
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jun 16, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.0 for 3.2.0 version backend bug Something isn't working Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [DAO] error sql in postgresql's dolphinscheduler_ddl.sql

4 participants