Skip to content

fix(ui): update node fill color after run flag changes#13669

Closed
moonkop wants to merge 3 commits intoapache:devfrom
moonkop:dev2
Closed

fix(ui): update node fill color after run flag changes#13669
moonkop wants to merge 3 commits intoapache:devfrom
moonkop:dev2

Conversation

@moonkop
Copy link
Contributor

@moonkop moonkop commented Mar 3, 2023

Purpose of the pull request

fix(ui): update node fill color after run flag changes

Brief change log

add setNodeFlag to dolphinscheduler-ui/src/views/projects/workflow/components/dag/use-cell-update.ts

Verify this pull request

Manually verified the change by testing locally.

@github-actions github-actions bot added the UI ui and front end related label Mar 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #13669 (ce15ff7) into dev (f0a34cd) will decrease coverage by 0.33%.
The diff coverage is 50.00%.

❗ Current head ce15ff7 differs from pull request most recent head 38722d7. Consider uploading reports for the commit 38722d7 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13669      +/-   ##
============================================
- Coverage     39.38%   39.05%   -0.33%     
- Complexity     4215     4401     +186     
============================================
  Files          1040     1129      +89     
  Lines         39158    42087    +2929     
  Branches       4482     4756     +274     
============================================
+ Hits          15424    16439    +1015     
- Misses        21958    23834    +1876     
- Partials       1776     1814      +38     
Impacted Files Coverage Δ
...eduler/plugin/alert/script/ScriptAlertChannel.java 16.66% <0.00%> (ø)
...cheduler/plugin/alert/dingtalk/DingTalkSender.java 34.13% <12.50%> (-0.78%) ⬇️
...dolphinscheduler/plugin/alert/http/HttpSender.java 47.69% <33.33%> (ø)
...olphinscheduler/plugin/alert/email/MailSender.java 51.03% <40.00%> (+0.34%) ⬆️
...cheduler/plugin/alert/email/EmailAlertChannel.java 47.61% <50.00%> (ø)
...ugin/alert/email/template/DefaultHTMLTemplate.java 79.24% <50.00%> (ø)
...hinscheduler/plugin/alert/script/ProcessUtils.java 60.00% <50.00%> (ø)
...hinscheduler/plugin/alert/feishu/FeiShuSender.java 46.55% <62.50%> (ø)
...olphinscheduler/plugin/alert/email/ExcelUtils.java 81.63% <66.66%> (ø)
...in/alert/dingtalk/DingTalkAlertChannelFactory.java 98.79% <100.00%> (ø)
... and 550 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@caishunfeng caishunfeng added the bug Something isn't working label Mar 6, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to an issue for this PR and describe why you want to do that.

@songjianet
Copy link
Member

Why do you need to do this? Can you create a corresponding issue? @moonkop

@github-actions
Copy link

github-actions bot commented Nov 3, 2023

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 3, 2023
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Stale UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants