Conversation
XiaochenNan
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #13715 +/- ##
============================================
+ Coverage 39.10% 39.13% +0.03%
- Complexity 4420 4430 +10
============================================
Files 1130 1130
Lines 42052 42052
Branches 4774 4774
============================================
+ Hits 16445 16459 +14
+ Misses 23792 23778 -14
Partials 1815 1815 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
issue is #13717 |
| TaskExecutionContext taskExecutionContext = new TaskExecutionContext(); | ||
| Assertions.assertFalse(ProcessUtils.kill(taskExecutionContext)); |
There was a problem hiding this comment.
@ruanwenjun updated setAppIds step, please check again, thanks.
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Our purpose of adding UT cases is to:
- Cover code lines / logic branches as much as possible in order to reduce bugs.
- Work as documentations for the covered code so that developers know what the covered code does.
Therefore, you need to cover as many methods and lines as you can in the UT cases.
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
6 participants
Purpose of the pull request
This pull request adds UT for some utils
Brief change log
ProcessUtilsTest.java
ArgsUtilsTest.java
Verify this pull request
This change added tests and can be verified as follows:
Added UT for ArgsUtils and ProcessUtils