Skip to content

[Improvement] Test DataSource connection return msg may not internati…#13767

Merged
caishunfeng merged 1 commit intoapache:devfrom
tracehh:dev1115
Mar 21, 2023
Merged

[Improvement] Test DataSource connection return msg may not internati…#13767
caishunfeng merged 1 commit intoapache:devfrom
tracehh:dev1115

Conversation

@tracehh
Copy link
Contributor

@tracehh tracehh commented Mar 17, 2023

…onalization

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #13767 (934fe7d) into dev (1ac76e1) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 934fe7d differs from pull request most recent head 3405fc9. Consider uploading reports for the commit 3405fc9 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13767      +/-   ##
============================================
- Coverage     39.03%   38.98%   -0.06%     
+ Complexity     4448     4442       -6     
============================================
  Files          1133     1133              
  Lines         42352    42352              
  Branches       4792     4792              
============================================
- Hits          16533    16509      -24     
- Misses        23992    24019      +27     
+ Partials       1827     1824       -3     
Impacted Files Coverage Δ
...eduler/api/service/impl/DataSourceServiceImpl.java 50.45% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng added 3.2.0 for 3.2.0 version improvement make more easy to user or prompt friendly labels Mar 21, 2023
@caishunfeng caishunfeng merged commit 1075be6 into apache:dev Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants