Skip to content

Dealing with table name case issues#13893

Closed
xinxingi wants to merge 8 commits intoapache:devfrom
xinxingi:dev
Closed

Dealing with table name case issues#13893
xinxingi wants to merge 8 commits intoapache:devfrom
xinxingi:dev

Conversation

@xinxingi
Copy link
Contributor

@xinxingi xinxingi commented Apr 7, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

xinxingi added 2 commits April 7, 2023 19:32
-- Dealing with table name case issues
drop PROCEDURE if EXISTS drop_qrtz_job_details_capitalization;
delimiter d//
CREATE PROCEDURE drop_qrtz_job_details_capitalization()
BEGIN
    IF EXISTS (SELECT 1 FROM INFORMATION_SCHEMA.STATISTICS
        WHERE TABLE_NAME='qrtz_job_details'
        AND TABLE_SCHEMA=(SELECT DATABASE())
                                )
    THEN
RENAME TABLE `qrtz_job_details` TO `QRTZ_JOB_DETAILS`;
END IF;
END;
d//
delimiter ;
CALL drop_qrtz_job_details_capitalization;
DROP PROCEDURE drop_qrtz_job_details_capitalization;
Handle the case of the table name, if the problem is not handled, the ddl statement may fail
@xinxingi xinxingi requested a review from zhongjiajie as a code owner April 7, 2023 11:38
@davidzollo davidzollo added the first time contributor First-time contributor label Apr 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2023

Codecov Report

Merging #13893 (10b35b3) into dev (d772f24) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 10b35b3 differs from pull request most recent head f9013ca. Consider uploading reports for the commit f9013ca to get more accurate results

@@             Coverage Diff              @@
##                dev   #13893      +/-   ##
============================================
- Coverage     38.91%   38.86%   -0.06%     
+ Complexity     4465     4453      -12     
============================================
  Files          1158     1158              
  Lines         42424    42424              
  Branches       4772     4776       +4     
============================================
- Hits          16510    16487      -23     
- Misses        24097    24121      +24     
+ Partials       1817     1816       -1     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@xinxingi
Copy link
Contributor Author

截屏2023-04-10 10 20 03
Still encountering some errors when starting the master

@xinxingi xinxingi changed the title Dealing with table name case issues Dealing with table name case issues,Upgrade script field missing problem Apr 10, 2023
@xinxingi xinxingi changed the title Dealing with table name case issues,Upgrade script field missing problem Dealing with table name case issues、Upgrade script field missing problem Apr 10, 2023
@xinxingi xinxingi changed the title Dealing with table name case issues、Upgrade script field missing problem Dealing with table name case issues Apr 10, 2023
@xinxingi xinxingi closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants