Skip to content

[Improvement-13570][Resource Center] Code clean up for old resource#14074

Closed
Radeity wants to merge 1 commit intoapache:devfrom
Radeity:Improvement-13570
Closed

[Improvement-13570][Resource Center] Code clean up for old resource#14074
Radeity wants to merge 1 commit intoapache:devfrom
Radeity:Improvement-13570

Conversation

@Radeity
Copy link
Member

@Radeity Radeity commented May 10, 2023

Purpose of the pull request

Brief change log

  • Remove authorization of resource and udf in Security Center.
  • Remove use of ResourceMapper.
  • Remove code for compatibility with old resource.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added backend UI ui and front end related labels May 10, 2023
@mergeable mergeable bot removed UI ui and front end related backend labels May 10, 2023
@SbloodyS SbloodyS added UI ui and front end related improvement make more easy to user or prompt friendly backend 3.2.0 for 3.2.0 version labels May 10, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone May 10, 2023
@Radeity
Copy link
Member Author

Radeity commented May 10, 2023

Hi, @caishunfeng , i modify code logic in StreamTaskExecuteRunnable.getResourceFullNames which keep the same with implementation of getResourceFullNames in TaskExecutionContextFactory, would you like to help check whether there's something wrong?

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #14074 (088254f) into dev (f1e7862) will decrease coverage by 0.06%.
The diff coverage is 9.09%.

❗ Current head 088254f differs from pull request most recent head a67c9c7. Consider uploading reports for the commit a67c9c7 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14074      +/-   ##
============================================
- Coverage     38.41%   38.35%   -0.06%     
+ Complexity     4476     4416      -60     
============================================
  Files          1228     1222       -6     
  Lines         42733    42042     -691     
  Branches       4727     4618     -109     
============================================
- Hits          16417    16127     -290     
+ Misses        24504    24143     -361     
+ Partials       1812     1772      -40     
Impacted Files Coverage Δ
...nscheduler/api/controller/ResourcesController.java 50.00% <ø> (-3.71%) ⬇️
...duler/api/controller/TaskDefinitionController.java 3.12% <ø> (+0.26%) ⬆️
...lphinscheduler/api/controller/UsersController.java 51.78% <ø> (-3.22%) ⬇️
...permission/ResourcePermissionCheckServiceImpl.java 99.13% <ø> (+0.67%) ⬆️
...heduler/api/service/impl/ResourcesServiceImpl.java 44.15% <ø> (+0.45%) ⬆️
...er/api/service/impl/TaskDefinitionServiceImpl.java 43.75% <ø> (-0.30%) ⬇️
...scheduler/api/service/impl/UdfFuncServiceImpl.java 67.25% <ø> (ø)
...inscheduler/api/service/impl/UsersServiceImpl.java 72.19% <ø> (+1.40%) ⬆️
...erver/master/runner/StreamTaskExecuteRunnable.java 0.00% <0.00%> (ø)
...er/runner/execute/TaskExecutionContextFactory.java 0.00% <0.00%> (ø)
... and 1 more

... and 46 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@Radeity Radeity force-pushed the Improvement-13570 branch from 74462fd to a67c9c7 Compare May 13, 2023 00:50
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

17.6% 17.6% Coverage
0.0% 0.0% Duplication

@Radeity Radeity marked this pull request as draft June 4, 2023 04:11
@zhongjiajie zhongjiajie modified the milestones: 3.2.0, 3.3.0 Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Jan 2, 2024

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 2, 2024
@github-actions
Copy link

github-actions bot commented Jan 9, 2024

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly Stale UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Resource Center] Code clean up and replace the usage of Resource

5 participants