[Feature] Add workflow instance log#14261
Closed
ruanwenjun wants to merge 1 commit intoapache:devfrom
Closed
Conversation
ruanwenjun
requested review from
SbloodyS,
caishunfeng,
kezhenxu94 and
zhongjiajie
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_addWorkflowInstanceLogDev
branch
from
9403afe to
e8289e6
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addWorkflowInstanceLogDev
branch
from
e8289e6 to
351cf4b
Compare
caishunfeng
changed the title
fuchanghai
requested changes
Aug 30, 2023
| }) | ||
| @GetMapping(value = "/log/view") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| @ApiException(QUERY_TASK_INSTANCE_LOG_ERROR) |
Member
There was a problem hiding this comment.
should we use QUERY_WORKFLOW_INSTANCE_LOG_ERROR instead of QUERY_TASK_INSTANCE_LOG_ERROR
| }) | ||
| @GetMapping(value = "/log/download") | ||
| @ResponseBody | ||
| @ApiException(DOWNLOAD_TASK_INSTANCE_LOG_FILE_ERROR) |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md