Skip to content

[Improvement-14280][Task] update the task execution status check#14281

Merged
zhuangchong merged 1 commit intoapache:devfrom
rickchengx:Improvement-14280
Jun 6, 2023
Merged

[Improvement-14280][Task] update the task execution status check#14281
zhuangchong merged 1 commit intoapache:devfrom
rickchengx:Improvement-14280

Conversation

@rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

  • add isForceSuccess() in isFinished()
  • delete getNeedFailoverWorkflowInstanceState, which is replaced by shouldFailover

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@rickchengx rickchengx added improvement make more easy to user or prompt friendly backend 3.2.0 for 3.2.0 version labels Jun 6, 2023
@rickchengx rickchengx requested a review from caishunfeng as a code owner June 6, 2023 03:09
@rickchengx rickchengx self-assigned this Jun 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #14281 (4b6cb07) into dev (d587b5f) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 4b6cb07 differs from pull request most recent head dcdbfeb. Consider uploading reports for the commit dcdbfeb to get more accurate results

@@             Coverage Diff              @@
##                dev   #14281      +/-   ##
============================================
- Coverage     38.43%   38.42%   -0.02%     
  Complexity     4496     4496              
============================================
  Files          1235     1235              
  Lines         42995    42989       -6     
  Branches       4766     4766              
============================================
- Hits          16526    16517       -9     
- Misses        24638    24644       +6     
+ Partials       1831     1828       -3     
Impacted Files Coverage Δ
...ler/plugin/task/api/enums/TaskExecutionStatus.java 55.26% <0.00%> (-3.83%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rickchengx
Copy link
Contributor Author

will merge tomorrow if no more comments

@zhuangchong zhuangchong merged commit 4d798e7 into apache:dev Jun 6, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Task] update the task execution status check

4 participants