[Improvement-14280][Task] update the task execution status check#14281
Merged
zhuangchong merged 1 commit intoapache:devfrom Jun 6, 2023
Merged
[Improvement-14280][Task] update the task execution status check#14281zhuangchong merged 1 commit intoapache:devfrom
zhuangchong merged 1 commit intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #14281 +/- ##
============================================
- Coverage 38.43% 38.42% -0.02%
Complexity 4496 4496
============================================
Files 1235 1235
Lines 42995 42989 -6
Branches 4766 4766
============================================
- Hits 16526 16517 -9
- Misses 24638 24644 +6
+ Partials 1831 1828 -3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
EricGao888
approved these changes
Jun 6, 2023
Contributor
Author
|
will merge tomorrow if no more comments |
zhuangchong
approved these changes
Jun 6, 2023
zhongjiajie
pushed a commit
that referenced
this pull request
Jul 20, 2023
) (cherry picked from commit 4d798e7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Purpose of the pull request
Brief change log
isForceSuccess()inisFinished()getNeedFailoverWorkflowInstanceState, which is replaced byshouldFailoverVerify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md