Skip to content

[Improvement-14292][Common] Remove the duplicate OSUtils#14293

Merged
caishunfeng merged 1 commit intoapache:devfrom
rickchengx:Improvement-14292
Jun 7, 2023
Merged

[Improvement-14292][Common] Remove the duplicate OSUtils#14293
caishunfeng merged 1 commit intoapache:devfrom
rickchengx:Improvement-14292

Conversation

@rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

  • delete OSUtils in task.api and alert.script

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@rickchengx rickchengx self-assigned this Jun 7, 2023
@rickchengx rickchengx added 3.2.0 for 3.2.0 version improvement make more easy to user or prompt friendly labels Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #14293 (3b5ca99) into dev (9298117) will increase coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head 3b5ca99 differs from pull request most recent head 8080da3. Consider uploading reports for the commit 8080da3 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14293      +/-   ##
============================================
+ Coverage     38.41%   38.55%   +0.13%     
+ Complexity     4497     4493       -4     
============================================
  Files          1235     1231       -4     
  Lines         42989    42818     -171     
  Branches       4765     4749      -16     
============================================
- Hits          16516    16509       -7     
+ Misses        24646    24479     -167     
- Partials       1827     1830       +3     
Impacted Files Coverage Δ
...hinscheduler/plugin/alert/script/ScriptSender.java 72.22% <ø> (ø)
.../apache/dolphinscheduler/common/utils/OSUtils.java 29.37% <0.00%> (-0.19%) ⬇️
...duler/plugin/task/api/AbstractCommandExecutor.java 0.00% <ø> (ø)
...nscheduler/plugin/task/api/utils/ProcessUtils.java 0.00% <ø> (ø)
...dolphinscheduler/plugin/kubeflow/KubeflowTask.java 90.16% <ø> (ø)
...olphinscheduler/plugin/task/mlflow/MlflowTask.java 59.20% <ø> (ø)
...heduler/plugin/task/pytorch/GitProjectManager.java 52.38% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 2c057d6 into apache:dev Jun 7, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Common] Remove the duplicate OSUtils

3 participants