[FIX-14299][api]: check schedule exists#14430
Merged
rickchengx merged 2 commits intoapache:devfrom Jul 13, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #14430 +/- ##
============================================
- Coverage 38.73% 38.72% -0.02%
- Complexity 4577 4579 +2
============================================
Files 1237 1237
Lines 43530 43537 +7
Branches 4822 4821 -1
============================================
- Hits 16860 16858 -2
- Misses 24798 24807 +9
Partials 1872 1872
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rickchengx
reviewed
Jul 4, 2023
...ler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java
Outdated
Show resolved
Hide resolved
davidzollo
previously requested changes
Jul 4, 2023
...ler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java
Outdated
Show resolved
Hide resolved
Contributor
|
rerun failed CI |
|
Kudos, SonarCloud Quality Gate passed! |
zhongjiajie
pushed a commit
that referenced
this pull request
Jul 20, 2023
* fix: check schedule exists * put error message in result --------- Co-authored-by: lutong <lutongtong211027@credithc.com> (cherry picked from commit 484f841)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #14299
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md