[CI][E2E] Try to fix e2e timeout error#14690
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #14690 +/- ##
============================================
- Coverage 38.74% 38.71% -0.03%
+ Complexity 4629 4627 -2
============================================
Files 1285 1285
Lines 43950 43950
Branches 4850 4850
============================================
- Hits 17027 17015 -12
- Misses 25042 25055 +13
+ Partials 1881 1880 -1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SbloodyS
added
CI&CD
minor
| .withLogConsumer("dolphinscheduler_1", outputFrame -> LOGGER.info(outputFrame.getUtf8String())) | ||
| .waitingFor("dolphinscheduler_1", Wait.forHealthcheck().withStartupTimeout(Duration.ofSeconds(300))); | ||
| .withLocalCompose(true) | ||
| .withExposedService(serviceName, DOCKER_PORT, Wait.forListeningPort().withStartupTimeout(Duration.ofSeconds(300))) |
There was a problem hiding this comment.
The main reason of e2e timeout is this. The rest are just minor optimizations.
zhongjiajie
left a comment
zhongjiajie
left a comment
There was a problem hiding this comment.
Thanks Hao, this is a huge improvement for our CI stable
| test: ["CMD", "curl", "-f", "http://localhost:9000/minio/health/live"] | ||
| interval: 5s | ||
| timeout: 300s | ||
| timeout: 5s |
There was a problem hiding this comment.
why we change this? to let others server wait less time?
There was a problem hiding this comment.
This is just the timeout for each retry, reducing it can improve the efficiency of the check.
https://docs.docker.com/engine/reference/builder/#healthcheck
* try to fix e2e timeout error * remove use file
|
This pr has already been merged. But Github is abnormal, Closing now. |
|
Kudos, SonarCloud Quality Gate passed!
|
* try to fix e2e timeout error * remove use file (cherry picked from commit dec5228)
3 participants
Purpose of the pull request
Try to fix e2e timeout error