[Improvement-14830][dolphinscheduler-storage-s3] Allow customization of s3 region#14831
Merged
caishunfeng merged 2 commits intoapache:devfrom Aug 31, 2023
lukeyan2023:Improvment-14830
Merged
[Improvement-14830][dolphinscheduler-storage-s3] Allow customization of s3 region#14831caishunfeng merged 2 commits intoapache:devfrom lukeyan2023:Improvment-14830
caishunfeng merged 2 commits intoapache:devfrom
lukeyan2023:Improvment-14830
Conversation
…ions Replace `Regions. fromName (region). getName() ` with the `region ` variable
Codecov Report
@@ Coverage Diff @@
## dev #14831 +/- ##
============================================
- Coverage 38.94% 38.94% -0.01%
+ Complexity 4602 4601 -1
============================================
Files 1232 1232
Lines 43254 43253 -1
Branches 4789 4789
============================================
- Hits 16844 16843 -1
Misses 24542 24542
Partials 1868 1868
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lukeyan2023
changed the title
SbloodyS
added
improvement
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Allow AWS S3 compatible Object storage using custom named regions
Brief change log
Replace
Regions. fromName (region). getName()with theregionvariableVerify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.mdThis closes #14830