Skip to content

[Feature-15148][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15148

Closed
xujiaqiang wants to merge 62 commits intoapache:devfrom
xujiaqiang:dev-xjq-alert-voice
Closed

[Feature-15148][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15148
xujiaqiang wants to merge 62 commits intoapache:devfrom
xujiaqiang:dev-xjq-alert-voice

Conversation

@xujiaqiang
Copy link
Contributor

@xujiaqiang xujiaqiang commented Nov 10, 2023

@xujiaqiang xujiaqiang changed the title [Feature-15147][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice [Feature-15148][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice Nov 10, 2023
@github-actions github-actions bot added UI ui and front end related backend labels Nov 10, 2023
xujiaqiang added 2 commits November 13, 2023 14:15
…q-alert-voice

# Conflicts:
#	dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertInputTips.java
#	dolphinscheduler-alert/dolphinscheduler-alert-plugins/pom.xml
#	dolphinscheduler-ui/src/locales/en_US/security.ts
#	dolphinscheduler-ui/src/locales/zh_CN/security.ts
@xujiaqiang xujiaqiang reopened this Nov 13, 2023
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no dependency changes, please do not submit the pnpm-lock file.

songjianet
songjianet previously approved these changes Nov 15, 2023
qingwli
qingwli previously approved these changes Nov 29, 2023
Copy link
Member

@qingwli qingwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingwli
Copy link
Member

qingwli commented Nov 29, 2023

Please fix UT. Add your new jar license like DEPENDENCIES

@xujiaqiang xujiaqiang requested a review from qingwli November 29, 2023 08:42
@github-actions github-actions bot added the e2e e2e test label Nov 29, 2023
davidzollo
davidzollo previously approved these changes Nov 29, 2023
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@zhongjiajie
Copy link
Member

could you format the code via mvn spotless:apply

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

58.3% 58.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend document e2e e2e test first time contributor First-time contributor UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice