[fix-#15176] [sql] If the value of the variable contains $ or / symbols, an error may be reported.

[fuchanghai]

Purpose of the pull request

• plz close this issue [Bug] [SQL] If the value of the variable contains $ or / symbols, an error may be reported.  #15176

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

[fuchanghai]

but when i run mvn spotless:apply I don't see any changes to the file cc @qingwli @EricGao888

[qingwli]

I have tested and works well.

Did you run this command in the ds root folder?

looks like you in UI folder

[fuchanghai]

I have tested and works well.

Did you run this command in the ds root folder?

looks like you in UI folder

thanks for you review,plz help me to run CI

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (308e4fb) 38.01% compared to head (36a853a) 38.04%.

❗ Current head 36a853a differs from pull request most recent head 3844662. Consider uploading reports for the commit 3844662 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15177      +/-   ##
============================================
+ Coverage     38.01%   38.04%   +0.02%     
- Complexity     4692     4694       +2     
============================================
  Files          1304     1304              
  Lines         44814    44818       +4     
  Branches       4804     4804              
============================================
+ Hits          17038    17051      +13     
+ Misses        25924    25915       -9     
  Partials       1852     1852              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fuchanghai]

@qingwli @ruanwenjun PTAL

[qingwli]

What's your test content was?

[fuchanghai]

What's your test content was?
hi @qingwli you can see #15176

[qingwli]

No content value

[fuchanghai]

No content value

content is this is ${a}
output parameter ,you can choose one of follow :

• key : a value : 99${aa}
• key : a value : 99$

[qingwli]

Works well for me? Any different?

[fuchanghai]

i'm sorry ,you can test this content select * from a where a != !{a}

[ruanwenjun]

Please add Ut for this, this issue is not clear.

[fuchanghai]

Please add Ut for this, this issue is not clear.

i will add UT, tomorrow

[fuchanghai]

Please add Ut for this, this issue is not clear.

dnoe

[fuchanghai]

Works well for me? Any different?

hi @qingwli I had add UT,PTAL

[qingwli]

@ruanwenjun PTAL

[fuchanghai]

@caishunfeng @SbloodyS PTAL

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

[github-actions]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.