Skip to content

[Improvement-15183][api] remove ApiException annotation #15276 #15291

Closed
zhengkezhou1 wants to merge 15 commits intoapache:devfrom
zhengkezhou1:dev-remove-api-exception
Closed

[Improvement-15183][api] remove ApiException annotation #15276 #15291
zhengkezhou1 wants to merge 15 commits intoapache:devfrom
zhengkezhou1:dev-remove-api-exception

Conversation

@zhengkezhou1
Copy link

Purpose of the pull request

the @ApiException is no need
this pull request slove #15183

Brief change log

  • change org/apache/dolphinscheduler/api/exceptions
  • change org/apache/dolphinscheduler/api/controller
  • change org/apache/dolphinscheduler/api/controller/v2
  • change test/org/apache/dolphinscheduler/api/exceptions

Verify this pull request

This pull request is already covered by existing tests, such as unit test

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Dec 17, 2023
@zhengkezhou1
Copy link
Author

screenshot-github com-2023 12 17-23_10_30
@ruanwenjun These are test cases for @ApiException that I think can be removed

@ruanwenjun
Copy link
Member

screenshot-github com-2023 12 17-23_10_30
@ruanwenjun These are test cases for @ApiException that I think can be removed

Yes, we can remove this test case.

@SbloodyS SbloodyS added the first time contributor First-time contributor label Dec 25, 2023
@kezhenxu94
Copy link
Member

Hi @zzzk1 , are you still working on this?

@zhengkezhou1
Copy link
Author

Hi @zzzk1 , are you still working on this?

yes

@zhengkezhou1 zhengkezhou1 closed this by deleting the head repository Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend first time contributor First-time contributor improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants