[API] [bug] dependent task need regenerate up-stream code when import#15492
[API] [bug] dependent task need regenerate up-stream code when import#15492xiaolailong wants to merge 5 commits intoapache:devfrom
Conversation
SbloodyS
left a comment
There was a problem hiding this comment.
Please link this pr to your issue. @xiaolailong
Thank you for reminding!There is no relevant issue, should I create one? |
issue is #15493 |
|
@xiaolailong plz run 'mvn spotless:apply' to fix these violations. |
|
hi @SbloodyS plz check #14956 |
Thanks. I overlooked some potential issues. I've replyed in #14956 (comment). |
Thank you for guideline! already done. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15492 +/- ##
============================================
- Coverage 38.01% 37.99% -0.03%
Complexity 4692 4692
============================================
Files 1304 1304
Lines 44814 44843 +29
Branches 4804 4812 +8
============================================
Hits 17038 17038
- Misses 25924 25953 +29
Partials 1852 1852 ☔ View full report in Codecov by Sentry. |
|
@xiaolailong Thanks for your contributions. Maybe we should also regenerate the task code when import other task types, such as SUB_PROCESS and CONDITIONS, what do u think? Can this replacement be done in a uniform way? |
|
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |


Purpose of the pull request
When import a dependent task from json file, the up-stream code of process and task is not re-generated, which cause the import error. (The import operation return success, but when you open the detail of dependend task, it will show many error message like: "can not found process definition")
fix #15493
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md