Skip to content

[API] [bug] dependent task need regenerate up-stream code when import#15492

Closed
xiaolailong wants to merge 5 commits intoapache:devfrom
xiaolailong:fix-import-depend-code-regenerate
Closed

[API] [bug] dependent task need regenerate up-stream code when import#15492
xiaolailong wants to merge 5 commits intoapache:devfrom
xiaolailong:fix-import-depend-code-regenerate

Conversation

@xiaolailong
Copy link

@xiaolailong xiaolailong commented Jan 16, 2024

Purpose of the pull request

When import a dependent task from json file, the up-stream code of process and task is not re-generated, which cause the import error. (The import operation return success, but when you open the detail of dependend task, it will show many error message like: "can not found process definition")

fix #15493

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link this pr to your issue. @xiaolailong

@SbloodyS SbloodyS added the first time contributor First-time contributor label Jan 16, 2024
@xiaolailong
Copy link
Author

Please link this pr to your issue. @xiaolailong

Thank you for reminding!There is no relevant issue, should I create one?

@xiaolailong
Copy link
Author

xiaolailong commented Jan 16, 2024

Please link this pr to your issue. @xiaolailong

issue is #15493

@fuchanghai
Copy link
Member

@xiaolailong plz run 'mvn spotless:apply' to fix these violations.

@fuchanghai
Copy link
Member

fuchanghai commented Jan 17, 2024

hi @SbloodyS plz check #14956
image
Importing subprocess, condition, switch, and dependcy is actually a type of problem. do we need to split it into multiple PRs to do it? . cc @EricGao888 @chenshuai1995 @ruanwenjun

@SbloodyS
Copy link
Member

Importing subprocess, condition, switch, and dependcy is actually a type of problem.

Thanks. I overlooked some potential issues. I've replyed in #14956 (comment).

@xiaolailong
Copy link
Author

@xiaolailong plz run 'mvn spotless:apply' to fix these violations.

Thank you for guideline! already done.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (308e4fb) 38.01% compared to head (279007d) 37.99%.
Report is 1 commits behind head on dev.

❗ Current head 279007d differs from pull request most recent head 2bf3b23. Consider uploading reports for the commit 2bf3b23 to get more accurate results

Files Patch % Lines
...api/service/impl/ProcessDefinitionServiceImpl.java 0.00% 40 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15492      +/-   ##
============================================
- Coverage     38.01%   37.99%   -0.03%     
  Complexity     4692     4692              
============================================
  Files          1304     1304              
  Lines         44814    44843      +29     
  Branches       4804     4812       +8     
============================================
  Hits          17038    17038              
- Misses        25924    25953      +29     
  Partials       1852     1852              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickchengx
Copy link
Contributor

@xiaolailong Thanks for your contributions. Maybe we should also regenerate the task code when import other task types, such as SUB_PROCESS and CONDITIONS, what do u think? Can this replacement be done in a uniform way?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label May 22, 2024
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.1 backend bug Something isn't working first time contributor First-time contributor Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Api] The up-stream process and task is shown error when import a dependent task

5 participants