[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type#15945
[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type#15945sdhzwc wants to merge 0 commit intoapache:devfrom sdhzwc:dev
Conversation
sdhzwc
requested review from
Amy0104,
EricGao888,
SbloodyS,
caishunfeng and
songjianet
as code owners
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Need to discuss at #15936.
sdhzwc
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15945 +/- ##
============================================
+ Coverage 39.85% 39.93% +0.07%
- Complexity 5060 5082 +22
============================================
Files 1369 1370 +1
Lines 45659 45653 -6
Branches 4872 4870 -2
============================================
+ Hits 18199 18232 +33
+ Misses 25560 25521 -39
Partials 1900 1900 ☔ View full report in Codecov by Sentry. |
...api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectParameterController.java
Outdated
Show resolved
Hide resolved
sdhzwc
changed the title
| JsonElement jsonElement = JsonParser.parseString(startParams); | ||
| boolean isJson = jsonElement.isJsonObject(); | ||
| if (isJson) { | ||
| Map<String, String> startParamMap = JSONUtils.toMap(startParams); | ||
| startParamList = startParamMap.entrySet().stream() | ||
| .map(entry -> new Property(entry.getKey(), Direct.IN, DataType.VARCHAR, entry.getValue())) | ||
| .collect(Collectors.toList()); | ||
| } else { | ||
| startParamList = JSONUtils.toList(startParams, Property.class); | ||
| } | ||
| } |
There was a problem hiding this comment.
Add a utils to transform the json to Propertity list
There was a problem hiding this comment.
Add a utils to transform the json to Propertity list
done
| JsonElement jsonElement = JsonParser.parseString(startParams); | ||
| boolean isJson = jsonElement.isJsonObject(); | ||
| if (isJson) { | ||
| Map<String, String> startParamMap = JSONUtils.toMap(startParams); | ||
| startParamList = startParamMap.entrySet().stream() | ||
| .map(entry -> new Property(entry.getKey(), Direct.IN, DataType.VARCHAR, entry.getValue())) | ||
| .collect(Collectors.toList()); | ||
| } else { | ||
| startParamList = JSONUtils.toList(startParams, Property.class); | ||
| } |
| if (startParamList != null && startParamList.size() > 0) { | ||
| cmdParam.put(CMD_PARAM_START_PARAMS, JSONUtils.toJsonString(startParamList)); |
There was a problem hiding this comment.
Use CollectionUtils.isNotEmpty(startParamList)
There was a problem hiding this comment.
Use
CollectionUtils.isNotEmpty(startParamList)
done
|
Frontend compile failed. |
done |
|
|
Sorry I push to your branch, but the pr auto closed, please reopen it. |
5 participants
close #15936
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md