[Improvement-16440][Alert] Improvement alert plugin get name#16441
Closed
sdhzwc wants to merge 1 commit intoapache:devfrom
sdhzwc:dev
Closed
[Improvement-16440][Alert] Improvement alert plugin get name#16441sdhzwc wants to merge 1 commit intoapache:devfrom sdhzwc:dev
sdhzwc wants to merge 1 commit intoapache:devfrom
sdhzwc:dev
Conversation
SbloodyS
reviewed
Aug 13, 2024
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
I don't think this optimization is necessary at this stage, because these names will only be initialized once and there is no need to reuse them.
ruanwenjun
requested changes
Aug 19, 2024
Comment on lines
+29
to
+42
| public enum AlertPluginType { | ||
|
|
||
| DINGTALK(0, "DingTalk", "ding talk"), | ||
| EMAIL(1, "Email", "email"), | ||
| FEISHU(2, "Feishu", "fei shu"), | ||
| HTTP(3, "Http", "http"), | ||
| PAGERDUTY(4, "PagerDuty", "pager duty"), | ||
| PROMETHEUS(5, "Prometheus", "prometheus alert manager"), | ||
| SCRIPT(6, "Script", "script"), | ||
| SLACK(7, "Slack", "slack"), | ||
| TELEGRAM(8, "Telegram", "telegram"), | ||
| WEBEXTEAMS(9, "WebexTeams", "webex teams"), | ||
| WECHAT(10, "WeChat", "we chat"), | ||
| ALIYUNVOICE(11, "AliyunVoice", "aliyun voice"); |
Member
There was a problem hiding this comment.
It's better don't add a enum here, otherwise, once we add a new plugin we should modify the enum.
We should make the plugin doesn't rely the other module.
Contributor
Author
There was a problem hiding this comment.
It's better don't add a enum here, otherwise, once we add a new plugin we should modify the enum. We should make the plugin doesn't rely the other module.
Referring to the DbType enumeration, isn't a new data source maintained in the same way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #16440
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md