[Improvement-16563][dolphinscheduler-task-plugin] optimize enum code#16564
Closed
LiJie20190102 wants to merge 1 commit intoapache:devfrom
Closed
[Improvement-16563][dolphinscheduler-task-plugin] optimize enum code#16564LiJie20190102 wants to merge 1 commit intoapache:devfrom
LiJie20190102 wants to merge 1 commit intoapache:devfrom
Conversation
LiJie20190102
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
SbloodyS
requested changes
Sep 2, 2024
Comment on lines
-54
to
-59
| for (TaskTimeoutStrategy es : values()) { | ||
| if (es.getCode() == status) { | ||
| return es; | ||
| } | ||
| } | ||
| throw new IllegalArgumentException("invalid status : " + status); |
Member
There was a problem hiding this comment.
This is meaningless since this enum only have 3 values. Please open another more meaningful pull request. @LiJie20190102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16563
Loading all enumeration values during initialization instead of iterating through them at once can improve performance
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md