[Chore] Fix UT will be skip at CI#18205
Merged
Merged
Conversation
SbloodyS
previously approved these changes
May 1, 2026
ruanwenjun
force-pushed
the
dev_wenjun_fixUTNotExecute
branch
from
005c379 to
f76d577
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixUTNotExecute
branch
from
c3ebfb5 to
2d60b39
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixUTNotExecute
branch
from
2d60b39 to
cf06cad
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixUTNotExecute
branch
from
cf06cad to
2465677
Compare
SbloodyS
previously approved these changes
May 2, 2026
…rtiesContext @DirtiesContext(AFTER_EACH_TEST_METHOD) destroys the Spring context but Spring's metrics auto-configuration does not remove the per-context MeterRegistry from Metrics.globalRegistry on shutdown, leaving dangling child registries that made counter reads in WorkflowInstanceMetricsTestCase return 0.0 in multi-IT runs. * Unbind the test method's MeterRegistry from Metrics.globalRegistry in @AfterEach on AbstractMasterIntegrationTestCase. * Drop the now-redundant cleanUpWorkflowInstanceCountMetricsByDefinitionCode call and baseline reads in WorkflowInstanceMetricsTestCase, since each test method starts with a fresh registry.
SbloodyS
approved these changes
May 2, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
NO
Purpose of the pull request
Donot skip UT at CI
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md