[Improvement-18249][DAO] Route TaskDefinitionMapper access through TaskDefinitionDao#18254
Merged
Conversation
ruanwenjun
force-pushed
the
dao/task-definition
branch
7 times, most recently
from
e41d523 to
d873622
Compare
…skDefinitionDao Encapsulate TaskDefinitionMapper behind TaskDefinitionDao so the api layer depends only on the repository abstraction. Add methods to TaskDefinitionDao: queryByName, queryByWorkerGroup, countByEnvironmentCode, queryByEnvironmentCodeAndWorkerGroup. The latter three replace inlined LambdaQueryWrapper builders that previously leaked mapper internals into the api layer. Switch three call sites in TaskDefinitionServiceImpl from int updateById to boolean: the (update & insert) != 1 check becomes !updateSuccess || insert != 1, the <=0 check becomes !switchSuccess, and the XOR check becomes updateSuccess != (updateLog == 1). TaskDefinitionServiceImplTest keeps its TaskDefinitionMapper mock for the @Injectmocks ProcessServiceImpl since the service module migration is out of scope. Tracking issue: apache#18249
ruanwenjun
force-pushed
the
dao/task-definition
branch
from
d873622 to
d9bda26
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, ops 4.7
Purpose of the pull request
Encapsulate TaskDefinitionMapper behind TaskDefinitionDao so the api layer depends only on the repository abstraction.
Add methods to TaskDefinitionDao: queryByName, queryByWorkerGroup, countByEnvironmentCode, queryByEnvironmentCodeAndWorkerGroup. The latter three replace inlined LambdaQueryWrapper builders that previously leaked mapper internals into the api layer.
Switch three call sites in TaskDefinitionServiceImpl from int updateById to boolean: the (update & insert) != 1 check becomes !updateSuccess || insert != 1, the <=0 check becomes !switchSuccess, and the XOR check becomes updateSuccess != (updateLog == 1).
TaskDefinitionServiceImplTest keeps its TaskDefinitionMapper mock for the @Injectmocks ProcessServiceImpl since the service module migration is out of scope.
Tracking issue: #18249
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md