[Improvement-18267][Remote Logging] Allow custom S3 region with endpoint

[wcmolin]

Was this PR generated or assisted by AI?

Yes

Purpose of the pull request

Close #18267

Allow S3-compatible storage, such as self-hosted MinIO, to use a custom region when aws.s3.endpoint is configured.

Previously, AmazonS3ClientFactory always called Regions.fromName(region), which rejected non-AWS region values before building the S3 client. For custom S3 endpoints, the configured region should be used as the signing region directly.

Brief change log

• Use the raw configured S3 region when aws.s3.endpoint is configured.
• Keep the existing AWS region validation when no custom S3 endpoint is configured.
• Add unit tests for custom endpoint region handling.

Verify this pull request

This change added tests and can be verified as follows:

• Added AmazonS3ClientFactoryTest to verify custom regions are allowed when an S3 endpoint is configured.
• Added test coverage to verify invalid custom regions are still rejected when no endpoint is configured.
• Added test coverage to verify empty regions are rejected when an endpoint is configured.
• Verified locally with:
  ./mvnw -pl dolphinscheduler-authentication/dolphinscheduler-aws-authentication test -Dtest=AmazonS3ClientFactoryTest -DskipITs

[ruanwenjun]

My concern #18267 (comment)

[SbloodyS]

LGTM

[Copilot]

Pull request overview

This PR improves the AWS authentication S3 client factory used by DolphinScheduler’s remote logging / S3 storage integrations by allowing non-AWS (custom) region strings when a custom aws.s3.endpoint is configured (e.g., MinIO), while keeping strict AWS region validation when no endpoint override is provided.

Changes:

• Use the raw configured region string as the signing region when aws.s3.endpoint is set, instead of validating via Regions.fromName(...).
• Add an explicit validation that aws.s3.region is non-empty when a custom endpoint is configured.
• Add unit tests covering custom endpoint + custom region, invalid custom region without endpoint, and empty region with endpoint.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
dolphinscheduler-authentication/dolphinscheduler-aws-authentication/src/main/java/org/apache/dolphinscheduler/authentication/aws/AmazonS3ClientFactory.java	Adjusts S3 client creation to bypass AWS region enum validation when using a custom endpoint, and adds empty-region validation for that mode.
dolphinscheduler-authentication/dolphinscheduler-aws-authentication/src/test/java/org/apache/dolphinscheduler/authentication/aws/AmazonS3ClientFactoryTest.java	Adds unit tests verifying the new endpoint/region behavior and expected validation outcomes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ruanwenjun]

LGTM

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud