Skip to content

[Fix-5199][TaskPlugin] Fix task process kill status check#18309

Closed
zhuxiangyi wants to merge 1 commit into
apache:devfrom
zhuxiangyi:fix-5199-task-kill-process-status
Closed

[Fix-5199][TaskPlugin] Fix task process kill status check#18309
zhuxiangyi wants to merge 1 commit into
apache:devfrom
zhuxiangyi:fix-5199-task-kill-process-status

Conversation

@zhuxiangyi

@zhuxiangyi zhuxiangyi commented Jun 1, 2026

Copy link
Copy Markdown

Purpose of the pull request

Fix task kill status checking when kill -0 returns Operation not permitted for an unkillable sudo parent process or when tenant login shell emits stderr with exit code 0.

Brief change log

  • Add exit code accessor to ExitCodeException.
  • Distinguish alive, not-alive, and no-permission process states in ProcessUtils.
  • Continue killing permitted child processes instead of reporting success when only the sudo parent check is denied.
  • Add unit coverage for sudo parent denied plus killable child processes.

Verify this pull request

  • ./mvnw -pl dolphinscheduler-common,dolphinscheduler-task-plugin/dolphinscheduler-task-api -DskipTests -Djacoco.skip=true spotless:check
  • ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-api -am -Dspotless.check.skip=true -Djacoco.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=ProcessUtilsTest test

@boring-cyborg

boring-cyborg Bot commented Jun 1, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@SbloodyS

SbloodyS commented Jun 1, 2026

Copy link
Copy Markdown
Member

Please follow the pull request notice first.

@SbloodyS SbloodyS closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants