[BUG-#4526][common]calculate cpu usage to support application running in container#4524
Merged
davidzollo merged 2 commits intoapache:devfrom Jan 24, 2021
Merged
[BUG-#4526][common]calculate cpu usage to support application running in container#4524davidzollo merged 2 commits intoapache:devfrom
davidzollo merged 2 commits intoapache:devfrom
Conversation
Member
|
hi, great contribution, but you need to resolve conflicting files first |
Codecov Report
@@ Coverage Diff @@
## dev #4524 +/- ##
============================================
- Coverage 44.76% 44.72% -0.05%
+ Complexity 3340 3336 -4
============================================
Files 527 527
Lines 22815 22820 +5
Branches 2667 2667
============================================
- Hits 10214 10206 -8
- Misses 11680 11695 +15
+ Partials 921 919 -2
Continue to review full report at Codecov.
|
Contributor
this is @crazycarry 's first contribution,I solved the conflict file |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
thanks for your first contribution, looking forward to your deep participation |
Member
|
notice:see #5198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when i user worker in container,the method just return hosts load,not the container load. i try to get the data from OperatingSystemMXBean,if it fails,just like before. in container env,you should make parms in worker. max.cpuload.avg bigger than cpucores *2, to avoid master do not dispatch task to the worker
this close #4526