Skip to content

[BUG-#4526][common]calculate cpu usage to support application running in container#4524

Merged
davidzollo merged 2 commits intoapache:devfrom
crazycarry:dev-local
Jan 24, 2021
Merged

[BUG-#4526][common]calculate cpu usage to support application running in container#4524
davidzollo merged 2 commits intoapache:devfrom
crazycarry:dev-local

Conversation

@crazycarry
Copy link
Contributor

@crazycarry crazycarry commented Jan 21, 2021

when i user worker in container,the method just return hosts load,not the container load. i try to get the data from OperatingSystemMXBean,if it fails,just like before. in container env,you should make parms in worker. max.cpuload.avg bigger than cpucores *2, to avoid master do not dispatch task to the worker

this close #4526

@CalvinKirs CalvinKirs added the first time contributor First-time contributor label Jan 21, 2021
@CalvinKirs CalvinKirs changed the title update get system load [Improvement][common]calculate cpu usage to support application running in container Jan 22, 2021
@CalvinKirs
Copy link
Member

hi, great contribution, but you need to resolve conflicting files first

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job
+1

@davidzollo davidzollo added this to the 1.3.5-release milestone Jan 24, 2021
@davidzollo davidzollo changed the title [Improvement][common]calculate cpu usage to support application running in container [BUG-#4526][common]calculate cpu usage to support application running in container Jan 24, 2021
@davidzollo davidzollo removed this from the 1.3.5-release milestone Jan 24, 2021
@codecov-io
Copy link

Codecov Report

Merging #4524 (b3f7ece) into dev (cfa88a4) will decrease coverage by 0.04%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #4524      +/-   ##
============================================
- Coverage     44.76%   44.72%   -0.05%     
+ Complexity     3340     3336       -4     
============================================
  Files           527      527              
  Lines         22815    22820       +5     
  Branches       2667     2667              
============================================
- Hits          10214    10206       -8     
- Misses        11680    11695      +15     
+ Partials        921      919       -2     
Impacted Files Coverage Δ Complexity Δ
.../apache/dolphinscheduler/common/utils/OSUtils.java 44.44% <28.57%> (-0.14%) 23.00 <1.00> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) 18.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa88a4...b3f7ece. Read the comment docs.

@davidzollo
Copy link
Contributor

hi, great contribution, but you need to resolve conflicting files first

this is @crazycarry 's first contribution,I solved the conflict file

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@davidzollo
Copy link
Contributor

thanks for your first contribution, looking forward to your deep participation

@davidzollo davidzollo merged commit 5bae933 into apache:dev Jan 24, 2021
lenboo pushed a commit that referenced this pull request Jan 31, 2021
@CalvinKirs
Copy link
Member

notice:see #5198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][WorkerServer] worker server doesn't work fine in K8s

4 participants