Skip to content

[Feature][API][backend] Query all upstream and downstream dependencies of the task#4778

Closed
IamMujuziMoses wants to merge 9 commits into
apache:devfrom
IamMujuziMoses:FeatureAPI-3797b
Closed

[Feature][API][backend] Query all upstream and downstream dependencies of the task#4778
IamMujuziMoses wants to merge 9 commits into
apache:devfrom
IamMujuziMoses:FeatureAPI-3797b

Conversation

@IamMujuziMoses

Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

  • Upstream Dependency
  • Downstream Dependency
  • Upstream and Downstream dependency

Brief change log

ProcessDefinitionController.java
ProcessDefinitionService.java
ProcessDefinitionServiceImpl.java

  • Added method queryUpstreamTaskDependencies
  • Added method queryDownstreamTaskDependencies

ProcessDefinitionControllerTest.java
ProcessDefinitionServiceTest.java

  • Added method testQueryUpstreamTaskDependencies
  • Added method testQueryDownstreamTaskDependencies

DependentParameters.java
DependentItem.java
DependentTaskModel.java

  • Added toString() method

Status.java

  • Added QUERY_TASK_DEPENDENCIES_BY_TASK_NAME_ERROR

Copy link
Copy Markdown
Contributor Author

@lgcareer I have been parsing the dependence field to get the downstream dependencies but I have failed to locate shell_02 or the equivalent information from the dependence field, where is that information stored?!
View in Slack

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #4778 (8d9ca4f) into dev (e851ec1) will decrease coverage by 0.03%.
The diff coverage is 81.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #4778      +/-   ##
============================================
- Coverage     47.28%   47.25%   -0.04%     
- Complexity     3689     3690       +1     
============================================
  Files           568      568              
  Lines         23891    23989      +98     
  Branches       2754     2771      +17     
============================================
+ Hits          11298    11336      +38     
- Misses        11567    11626      +59     
- Partials       1026     1027       +1     
Impacted Files Coverage Δ Complexity Δ
...e/dolphinscheduler/common/model/DependentItem.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...phinscheduler/common/model/DependentTaskModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ler/common/task/dependent/DependentParameters.java 10.00% <0.00%> (-1.12%) 1.00 <0.00> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 69.93% <82.55%> (+1.37%) 126.00 <18.00> (+18.00)
...er/api/controller/ProcessDefinitionController.java 73.87% <100.00%> (+2.02%) 22.00 <2.00> (+2.00)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...he/dolphinscheduler/remote/utils/ChannelUtils.java 16.66% <0.00%> (-16.67%) 1.00% <0.00%> (ø%)
...lphinscheduler/remote/future/ReleaseSemaphore.java 85.71% <0.00%> (-14.29%) 2.00% <0.00%> (-1.00%)
...duler/server/registry/ZookeeperRegistryCenter.java 48.83% <0.00%> (-13.96%) 14.00% <0.00%> (-3.00%)
...olphinscheduler/server/registry/HeartBeatTask.java 24.39% <0.00%> (-7.32%) 1.00% <0.00%> (-1.00%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e851ec1...8d9ca4f. Read the comment docs.

@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2021

Copy link
Copy Markdown

@IamMujuziMoses

Copy link
Copy Markdown
Contributor Author

Hi @lgcareer @dailidong sonar is reporting some code smell and vulnerability but for the code smell, that is the needed return type and for the vulnerability, we need to log the user-controlled data as protocol, so that is a mistake in the sonar results

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4778 (ad1cf06) into dev (5f1fc46) will increase coverage by 0.02%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #4778      +/-   ##
============================================
+ Coverage     48.81%   48.84%   +0.02%     
- Complexity     3836     3847      +11     
============================================
  Files           570      570              
  Lines         24158    24254      +96     
  Branches       2800     2817      +17     
============================================
+ Hits          11793    11847      +54     
- Misses        11284    11322      +38     
- Partials       1081     1085       +4     
Impacted Files Coverage Δ Complexity Δ
...e/dolphinscheduler/common/model/DependentItem.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...phinscheduler/common/model/DependentTaskModel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ler/common/task/dependent/DependentParameters.java 10.00% <0.00%> (-1.12%) 1.00 <0.00> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 69.70% <82.14%> (+1.31%) 126.00 <18.00> (+18.00)
...er/api/controller/ProcessDefinitionController.java 78.78% <100.00%> (+1.08%) 23.00 <2.00> (+2.00)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
...inscheduler/service/zk/CuratorZookeeperClient.java 70.73% <0.00%> (-4.88%) 9.00% <0.00%> (-1.00%)
...eduler/server/worker/runner/TaskExecuteThread.java 56.83% <0.00%> (-4.32%) 14.00% <0.00%> (-1.00%)
...dolphinscheduler/service/zk/ZookeeperOperator.java 36.27% <0.00%> (-3.93%) 14.00% <0.00%> (-2.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1fc46...ad1cf06. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

@kezhenxu94

Copy link
Copy Markdown
Member

It's been 1+ year and too many conflicts, let me close this and @IamMujuziMoses if you are interesting in continue please feel free to rebase the branch and open a new PR

@kezhenxu94 kezhenxu94 closed this Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants