Skip to content

[Improvement][API] Status code should one category one interval #4855#5050

Closed
yakcy wants to merge 11 commits intoapache:devfrom
yakcy:dev
Closed

[Improvement][API] Status code should one category one interval #4855#5050
yakcy wants to merge 11 commits intoapache:devfrom
yakcy:dev

Conversation

@yakcy
Copy link
Contributor

@yakcy yakcy commented Mar 14, 2021

Purpose of the pull request

[Improvement][API] Status code should one category one interval #4855

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@CalvinKirs CalvinKirs added the improvement make more easy to user or prompt friendly label Mar 15, 2021
@CalvinKirs
Copy link
Member

image
Here is a compilation error, you can check the specific class and fix the error.
Code Style Check fail, you can view this document (https://dolphinscheduler.apache.org/zh-cn/community/dev

@CalvinKirs CalvinKirs added the Waiting for user feedback Waiting for feedback from issue/PR author label Mar 18, 2021
yakcy added 2 commits March 20, 2021 17:02
…ary category(2 digits)-Three-level category(3 digits)
…ary category(2 digits)-Three-level category(3 digits)
Copy link
Contributor Author

@yakcy yakcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add check style ok~

@davidzollo
Copy link
Contributor

sorry for review so late, can you submit a new PR or solve the Conflicting files? I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement make more easy to user or prompt friendly Waiting for user feedback Waiting for feedback from issue/PR author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants