[Improvement][Service] Modify ordinary users tenants#5185
Closed
zombietramp wants to merge 6 commits into
Closed
Conversation
2:增加流程定义sql语句不能有多条语句的提示，运行时候自动截取以;结尾的第一条语句 3:修改sql语句动态where 代替 where 1=1 4:修改template 不支持v-show命令
Member
|
@zombietramp Please use English, and resolve the conflicts. |
added 2 commits
March 31, 2021 16:18
…ql语句动态where 代替 where 1=1 4:修改template 不支持v-show命令
# Conflicts: # dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
CalvinKirs
added
the
Waiting for user feedback
Member
|
Thanks for your contribution. Your PR title does not seem to match the description. |
ruanwenjun
reviewed
Apr 2, 2021
| join t_ds_project p on p.id=d.project_id | ||
| where 1 = 1 | ||
| and t.is_sub_process = 0 | ||
| where and t.is_sub_process = 0 |
| @@ -0,0 +1 @@ | |||
| 32432423 No newline at end of file | |||
| @@ -0,0 +1 @@ | |||
| 正正正faffdasfasdfas No newline at end of file | |||
| <mapper namespace="org.apache.dolphinscheduler.dao.mapper.UserMapper"> | ||
| <sql id="baseSql"> | ||
| id, user_name, user_password, user_type, email, phone, tenant_id, create_time, update_time, queue, state | ||
| id, user_name, user_password, user_type, email, phone, tenant_id, create_time, update_time, queue, `state` |
Member
There was a problem hiding this comment.
For the Sql style consistency, maybe it better not to make this modification ~~
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.*; |
Member
There was a problem hiding this comment.
The use of import * is considered a bad practice
…tenants
Scenario: After the bank's internal administrator creates a new ordinary user and assigns a tenant. No other tenants can be selected after the new process
2: Increase the process definition sql statement can not have multiple statement prompts, the first statement ending with; is automatically intercepted when running
If there are multiple sql after sql, run error
3: Modify sql statement dynamic where instead of where 1=1
zombietramp
changed the title
added 2 commits
April 5, 2021 10:54
1: Modify ordinary users and disable the function of selecting other tenants Scenario: After the bank's internal administrator creates a new ordinary user and assigns a tenant. No other tenants can be selected after the new process
Member
|
Thank you for your contribution, but since this issue has not been dealt with for a long time, I will close it. If you still have problems in the future, you can re-submit a new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1: Modify ordinary users and disable the function of selecting other tenants Scenario: After the bank's internal administrator creates a new ordinary user and assigns a tenant. No other tenants can be selected after the new process
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: