Skip to content

[Bug][worker] Fix sql task query result is empty (#5322)#5324

Merged
CalvinKirs merged 4 commits intoapache:devfrom
ruanwenjun:dev_wenjun_fix5322
Apr 22, 2021
Merged

[Bug][worker] Fix sql task query result is empty (#5322)#5324
CalvinKirs merged 4 commits intoapache:devfrom
ruanwenjun:dev_wenjun_fix5322

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Apr 19, 2021

Purpose of the pull request

close #5322

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 19, 2021

Codecov Report

Merging #5324 (cb37f7e) into dev (837c9ba) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5324      +/-   ##
============================================
- Coverage     48.76%   48.70%   -0.06%     
+ Complexity     3830     3826       -4     
============================================
  Files           570      570              
  Lines         24159    24160       +1     
  Branches       2800     2801       +1     
============================================
- Hits          11780    11766      -14     
- Misses        11298    11311      +13     
- Partials       1081     1083       +2
Impacted Files Coverage Δ Complexity Δ
...lphinscheduler/server/worker/task/sql/SqlTask.java 7.42% <0.00%> (-0.04%) 2.00 <0.00> (ø)
...eduler/server/worker/runner/TaskExecuteThread.java 56.83% <0.00%> (-4.32%) 14.00% <0.00%> (-1.00%)
...er/master/processor/queue/TaskResponseService.java 67.12% <0.00%> (-4.11%) 8.00% <0.00%> (ø%)
...dolphinscheduler/service/zk/ZookeeperOperator.java 36.27% <0.00%> (-3.93%) 14.00% <0.00%> (-2.00%)
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) 18.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837c9ba...cb37f7e. Read the comment docs.

@ruanwenjun ruanwenjun mentioned this pull request Apr 20, 2021
Closed
@chengshiwen
Copy link
Copy Markdown
Member

chengshiwen commented Apr 21, 2021

@ruanwenjun Hi, wenjun, is there a way to improve the unit test coverage?

@ruanwenjun
Copy link
Copy Markdown
Member Author

ruanwenjun commented Apr 21, 2021

@ruanwenjun Hi, wenjun, is there a way to improve the unit test coverage?

I suspect there is a problem with the unit test coverage statistics 😃

ysrotciv
ysrotciv reviewed Apr 21, 2021
View reviewed changes
Copy link
Copy Markdown

@ysrotciv ysrotciv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 21, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

CalvinKirs
CalvinKirs approved these changes Apr 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs
Copy link
Copy Markdown
Member

CalvinKirs commented Apr 22, 2021

@ruanwenjun Hi, wenjun, is there a way to improve the unit test coverage?

I suspect there is a problem with the unit test coverage statistics 😃

PowerMock nie wykrywa poprawnie pokrycia w przypadkach takich jak ten

@CalvinKirs CalvinKirs dismissed chengshiwen’s stale review April 22, 2021 04:02

PowerMock nie wykrywa poprawnie pokrycia w przypadkach takich jak ten

@CalvinKirs CalvinKirs added this to the 1.3.7-release milestone Apr 22, 2021
@CalvinKirs CalvinKirs merged commit abdd233 into apache:dev Apr 22, 2021
@ruanwenjun ruanwenjun deleted the dev_wenjun_fix5322 branch April 24, 2021 04:19
@CalvinKirs CalvinKirs modified the milestones: 1.3.7-release, 1.4.0 Jul 20, 2021
@VVeggie VVeggie mentioned this pull request Oct 27, 2023
Open
@ulnit ulnit mentioned this pull request Oct 27, 2023
Closed
This was referenced Oct 28, 2023
Open
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Oct 28, 2023
Open
@lucassasha lucassasha mentioned this pull request Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@chengshiwen chengshiwen chengshiwen left review comments

+1 more reviewer

@ysrotciv ysrotciv ysrotciv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

[Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception

5 participants

@ruanwenjun @codecov-commenter @chengshiwen @CalvinKirs @ysrotciv