Skip to content

[Bug][Service] All tasks that need to send attachment will fail due to chennel idle#5442

Merged
CalvinKirs merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fix_netty_heartbeat
May 10, 2021
Merged

[Bug][Service] All tasks that need to send attachment will fail due to chennel idle#5442
CalvinKirs merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fix_netty_heartbeat

Conversation

@ruanwenjun
Copy link
Member

Fix the heartbeat packets can't send problem, close #5427

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs added the bug Something isn't working label May 10, 2021
@CalvinKirs CalvinKirs added this to the 1.3.7-release milestone May 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #5442 (bbee0ce) into dev (d93a9dc) will increase coverage by 3.25%.
The diff coverage is 44.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5442      +/-   ##
============================================
+ Coverage     45.21%   48.47%   +3.25%     
- Complexity     3395     3856     +461     
============================================
  Files           538      598      +60     
  Lines         23053    24294    +1241     
  Branches       2687     2782      +95     
============================================
+ Hits          10423    11776    +1353     
+ Misses        11698    11444     -254     
- Partials        932     1074     +142     
Impacted Files Coverage Δ Complexity Δ
...inscheduler/plugin/alert/email/EmailConstants.java 87.50% <ø> (ø) 1.00 <0.00> (ø)
...eduler/plugin/alert/script/ScriptAlertChannel.java 16.66% <0.00%> (ø) 1.00 <0.00> (ø)
...org/apache/dolphinscheduler/alert/AlertServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...che/dolphinscheduler/api/ApiApplicationServer.java 33.33% <0.00%> (ø) 1.00 <0.00> (ø)
...cheduler/api/controller/AccessTokenController.java 6.66% <ø> (-1.67%) 1.00 <0.00> (-1.00)
...scheduler/api/controller/AlertGroupController.java 8.00% <ø> (+2.73%) 2.00 <0.00> (ø)
.../api/controller/AlertPluginInstanceController.java 7.69% <ø> (+1.97%) 2.00 <0.00> (ø)
...heduler/api/controller/DataAnalysisController.java 9.09% <ø> (ø) 1.00 <0.00> (-1.00)
...scheduler/api/controller/DataSourceController.java 4.16% <0.00%> (-0.49%) 1.00 <0.00> (-1.00)
...inscheduler/api/controller/ExecutorController.java 8.33% <ø> (-2.78%) 1.00 <0.00> (-1.00)
... and 298 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25727d2...bbee0ce. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.4% 15.4% Coverage
0.0% 0.0% Duplication

@CalvinKirs CalvinKirs merged commit fbef290 into apache:dev May 10, 2021
felix-thinkingdata added a commit to felix-thinkingdata/incubator-dolphinscheduler that referenced this pull request Jul 6, 2021
…o chennel idle (apache#5442)

# Conflicts:
#	dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/handler/NettyClientHandler.java
@ruanwenjun ruanwenjun deleted the dev_wenjun_fix_netty_heartbeat branch July 9, 2021 13:54
CalvinKirs added a commit that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Service] All tasks that need to send attachment will fail due to chennel idle

3 participants