[Improvement-5452][Task] ds flink task support submit a PyFlink job via the CLI#5453
Merged
CalvinKirs merged 4 commits intoapache:devfrom Jun 17, 2021
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #5453 +/- ##
============================================
- Coverage 45.33% 45.31% -0.02%
+ Complexity 3674 3670 -4
============================================
Files 607 607
Lines 24780 24780
Branches 2801 2801
============================================
- Hits 11234 11230 -4
Misses 12479 12479
- Partials 1067 1071 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Kudos, SonarCloud Quality Gate passed! |
chengshiwen
requested changes
May 12, 2021
| public static final String FLINK_MAIN_CLASS = "-c"; | ||
| public static final String FLINK_PARALLELISM = "-p"; | ||
| public static final String FLINK_SHUTDOWN_ON_ATTACHED_EXIT = "-sae"; | ||
| public static final String FLINK_CLI_OPTION_PYTHON = "-py"; |
Member
There was a problem hiding this comment.
I think maybe FLINK_PYTHON is shorter and better
| if (ProgramType.PYTHON == programType) { | ||
| // -py | ||
| args.add(Constants.FLINK_CLI_OPTION_PYTHON); | ||
| } |
Member
There was a problem hiding this comment.
These lines should not place here. It's better to modify them to:
if (programType != null) {
if (programType == ProgramType.PYTHON) {
args.add(Constants.FLINK_PYTHON); //-py
} else if (StringUtils.isNotEmpty(mainClass)) {
args.add(Constants.FLINK_MAIN_CLASS); //-c
args.add(param.getMainClass()); //main class
}
}
Member
|
@zhuangchong Hi, how is it getting? |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
this close #5452
ds flink task support submit a PyFlink job via the CLI