Skip to content

[Test] Add SparkParameters test#5478

Merged
davidzollo merged 3 commits intoapache:devfrom
QuakeWang:add-test
May 22, 2021
Merged

[Test] Add SparkParameters test#5478
davidzollo merged 3 commits intoapache:devfrom
QuakeWang:add-test

Conversation

@QuakeWang
Copy link
Contributor

Purpose of the pull request

Add a test case about SparkParameters.

@codecov-commenter
Copy link

Codecov Report

Merging #5478 (52f6ed8) into dev (d93a9dc) will increase coverage by 1.24%.
The diff coverage is 56.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5478      +/-   ##
============================================
+ Coverage     45.21%   46.46%   +1.24%     
- Complexity     3395     3779     +384     
============================================
  Files           538      608      +70     
  Lines         23053    24936    +1883     
  Branches       2687     2836     +149     
============================================
+ Hits          10423    11586    +1163     
- Misses        11698    12247     +549     
- Partials        932     1103     +171     
Impacted Files Coverage Δ Complexity Δ
...inscheduler/plugin/alert/email/EmailConstants.java 87.50% <ø> (ø) 1.00 <0.00> (ø)
...eduler/plugin/alert/script/ScriptAlertChannel.java 16.66% <0.00%> (ø) 1.00 <0.00> (ø)
...org/apache/dolphinscheduler/alert/AlertServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...che/dolphinscheduler/api/ApiApplicationServer.java 33.33% <0.00%> (ø) 1.00 <0.00> (ø)
...cheduler/api/controller/AccessTokenController.java 6.66% <ø> (-1.67%) 1.00 <0.00> (-1.00)
...scheduler/api/controller/AlertGroupController.java 8.00% <ø> (+2.73%) 2.00 <0.00> (ø)
.../api/controller/AlertPluginInstanceController.java 7.69% <ø> (+1.97%) 2.00 <0.00> (ø)
...heduler/api/controller/DataAnalysisController.java 9.09% <ø> (ø) 1.00 <0.00> (-1.00)
...scheduler/api/controller/DataSourceController.java 4.16% <0.00%> (-0.49%) 1.00 <0.00> (-1.00)
...inscheduler/api/controller/ExecutorController.java 8.33% <ø> (-2.78%) 1.00 <0.00> (-1.00)
... and 372 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04f4b6...52f6ed8. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo merged commit 46660b5 into apache:dev May 22, 2021
@QuakeWang QuakeWang deleted the add-test branch May 29, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants