Skip to content

[Improvement-5577][ui]add project name#5579

Closed
wengieeee wants to merge 1 commit intoapache:devfrom
wengieeee:origin/issue-5577
Closed

[Improvement-5577][ui]add project name#5579
wengieeee wants to merge 1 commit intoapache:devfrom
wengieeee:origin/issue-5577

Conversation

@wengieeee
Copy link

@wengieeee wengieeee commented Jun 2, 2021

Purpose of the pull request

issue-5577
This closes #5577

Brief change log

Change the title “Project Home” to the corresponding project name

Verify this pull request

This pull request is code cleanup without any test coverage.

@wengieeee
Copy link
Author

image

@chengshiwen chengshiwen added the first time contributor First-time contributor label Jun 2, 2021
Copy link
Member

@chengshiwen chengshiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to consider the overflow problem caused by too long text. Compared with mapState('dag', ['projectName']), calling localStorage.getItem('projectName') is also not a better choice. More detail please refer to #5568

@codecov-commenter
Copy link

Codecov Report

Merging #5579 (e2d6152) into dev (a5a0c7c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5579      +/-   ##
============================================
+ Coverage     46.86%   46.87%   +0.01%     
- Complexity     3790     3791       +1     
============================================
  Files           605      605              
  Lines         24800    24800              
  Branches       2811     2811              
============================================
+ Hits          11622    11625       +3     
+ Misses        12069    12068       -1     
+ Partials       1109     1107       -2     
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 83.05% <0.00%> (+1.69%) ⬆️
...r/server/worker/processor/TaskCallbackService.java 41.26% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a0c7c...e2d6152. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chengshiwen
Copy link
Member

Need to consider the overflow problem caused by too long text. Compared with mapState('dag', ['projectName']), calling localStorage.getItem('projectName') is also not a better choice. More detail please refer to #5568

Sorry, close this pr since #5568 has resolved the issue. Look forward to contribute!

@github-actions
Copy link

Hi:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][UI] Add Project Name in Project Page

3 participants