Skip to content

[Fix-5549][WorkerServer] SqlTask NullPointerException #5549#5590

Closed
didiaode18 wants to merge 1 commit intoapache:devfrom
didiaode18:dev
Closed

[Fix-5549][WorkerServer] SqlTask NullPointerException #5549#5590
didiaode18 wants to merge 1 commit intoapache:devfrom
didiaode18:dev

Conversation

@didiaode18
Copy link
Contributor

Purpose of the pull request

This close #5549.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@didiaode18 didiaode18 changed the title [Bug][WorkerServer] SqlTask NullPointerException #5549 [Fix-5549][WorkerServer] SqlTask NullPointerException #5549 Jun 4, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ruanwenjun
Copy link
Member

@didiaode18
The main problem in this issue #5549 might be that the value in the sqlParamsMap may be null.
And there is a same pr #5556

@CalvinKirs
Copy link
Member

Sorry, someone submitted PR before you.
If the original PR has not been updated for a long time (usually two weeks),
we will accept the new PR.

@CalvinKirs CalvinKirs added the duplicate This issue or pull request already exists label Jun 5, 2021
@didiaode18
Copy link
Contributor Author

Thank you for your reminder, how to deal with the pr that has not been merged under the consultation will not affect my next submission @ruanwenjun @CalvinKirs

@CalvinKirs
Copy link
Member

Deeply thanks for your contribution to this.
According to the open-source culture, who submit first, who get merged, if it is good enough.,
Therefore, I will close this PR. I am very sorry for that. I look forward to your continued contribution. If you encounter any problems, please feel free to communicate with me.

@CalvinKirs CalvinKirs closed this Jun 16, 2021
@CalvinKirs
Copy link
Member

Thank you for your reminder, how to deal with the pr that has not been merged under the consultation will not affect my next submission @ruanwenjun @CalvinKirs

It is best to check if someone has submitted a PR before submitting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][WorkerServer] SqlTask NullPointerException

3 participants